[D7] DC Scratch

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Hello dimple_chandra

Install and work find for me.

I tested your code with pareview.sh and it return this : http://pareview.sh/pareview/httpgitdrupalorgsandboxdimplechandra2235061git

For the first remark pareview says that your page.tpl.php it's not encoding correctly. You need to use UTF-8 encoding for your file.

The second part of remark :
5 | ERROR | Missing file doc comment => you need to add @file to the begining of your file and to give a description of your file. Take an example of the page.tpl.php in one of theme drupal core.

5 | ERROR | End of line character is invalid; expected "\n" but found "\r" => for this error it's a result of the first remark from pareview.sh

Nice work. And thanks for your contribution.

3rd party code/content

No:

The theme/module comes bundled with responsive-nav.js
responsive-nav.jsappears to be third party code/content (Copyright (c) 2013 @viljamis). Third party code/content/assets is not generally allowed on Drupal.org and should be deleted.
This particular asset is made available under the MIT license. his is considered a GPL-compatible license, which is usually allowed, but explicit permission to use from Drupal.org webmasters is still required.
This policy is described in the 3rd party libraries and content on Drupal.org. It also appears in the Drupal Git Repository Usage policy you agreed to when you signed up for Git access, which you may want to re-read, to be sure you're not violating other terms.
The Libraries API module is a recommended method for adding 3rd party dependencies without directly including the code on Drupal.org.

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.

Add Favicon
Add Features in .info file is good.

Header is more big, hide more content when scroll down.

but is a good jobs :)

you need to add @file to the begining of your file and to give a description of your file before line no. 4 for remove error from http://pareview.sh/pareview/httpgitdrupalorgsandboxdimplechandra2235061git

Automated Review

Pass

Manual Review

Individual user account

Yes: Follows the guidelines for individual user accounts.

No duplication

Yes: Does not cause module duplication and/or fragmentation.

Master Branch

Yes: Follows the guidelines for master branch.

Licensing

Yes: Follows the licensing requirements.

3rd party assets/code

Yes: Follows the guidelines for 3rd party assets/code.

README.txt/README.md

No: Does not follow the guidelines for in-project documentation and/or the README Template.

Code long/complex enough for review

Yes: Follows the guidelines for project length and complexity.

Secure code

[Yes: Meets the security requirements. / No: List of security issues identified.]

Coding style & Drupal API usage

[List of identified issues in no particular order. Use (*) and (+) to indicate an issue importance. Replace the text below by the issues themselves:

1. (*) Please significantly reduce the file size of the screenshot image in the module; it should not need to be 213KB.
2. (+) A lot more information is needed in the readme file and on the project page. Use one of the popular themes such as Fusion, Zen as a guide. In particular, you =should provide an answer to 'Why would I use this rather than, for example, Omega 4?'

The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.

If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.

This review uses the Project Application Review Template.

Hi

Thanks for compressing the screenshot. I asked because the module's version of the image is only seen very occasionally and then usually very small. Reducing it to e.g. 256x384px would be beneficial. You can of course upload a larger image onto the drupal.org project page, where it is more useful.

I am not a security expert but I still have concerns about the security side, which is why I don't think this is ready to go at this time.

The Readme.txt is improved but the question I posed - why use this theme - is still relevant, as you suggest it is appropriate for a huge range of cases. Specific improvements would be:

- Don't say 'IE7+' but state which versions you have tested. IE7+ will be wrong (at some point) when a new IE is released.
- You haven't indicated anything about Chrome, etc, versions. I accept that is more difficult because versions change quickly ; perhaps it would be better to state what features are relied on - CSS2 ? CSS3? SVG? etc
- It would be sensible to include a note about this being a base theme and to modify it using a sub-theme (and say how to do that). IMO this is always appropriate for themes from d.o. as it gives you (the creator) a way to update with new features and/or fixes.

Review of the 7.x-1.x branch (commit 1cae586):

• Coder Sniffer has found some issues with your code (please check the Drupal coding standards).
  

  FILE: /home/klausi/pareview_temp/templates/page.tpl.php
  ----------------------------------------------------------------------
  FOUND 1 ERROR AFFECTING 1 LINE
  ----------------------------------------------------------------------
   3 | ERROR | The second line in the file doc comment must be "@file"
  ----------------------------------------------------------------------
  
  FILE: /home/klausi/pareview_temp/template.php
  ----------------------------------------------------------------------
  FOUND 1 ERROR AFFECTING 1 LINE
  ----------------------------------------------------------------------
   4 | ERROR | The second line in the file doc comment must be "@file"
  ----------------------------------------------------------------------
  

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.

manual review:

1. dc_scratch_html_head_alter(): doc block is wrong, this is a hook implementation and should be documented as such, see https://www.drupal.org/coding-standards/docs#hooks . And why do you need to replace the charset, isn't utf-8 the default in Drupal? Please add a comment.
2. page.tpl.php: don't use base_path() here, use url() instead.
3. page.tpl.php: "Log In" is user facing text and must run through t() for translation.

But otherwise looks good to me. Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.

Assigning to ELC as he might have time to take a final look at this.

no objections for more than a week, so ...

Thanks for your contribution, dimple_chandra!

I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.