[D7] IP2Location Module

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxhexasoft2050979git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Hi

You never close any file on drupal ... "?>" This is very important.

You need 7.x branch into git repository and delete master branch.

Clear unnecessary commented code at line 65-73 to includes/ip2location.admin.inc and don't respect indentation on line 45.

License.txt is agreed by drupal, you don't need it.

In general you need review coding standards https://drupal.org/node/318

Duplication

There is already exists a lot of location modules for Drupal. Here is a list with those I am aware of:

• https://www.drupal.org/project/smart_ip
• https://www.drupal.org/project/IPtoLocation
• https://www.drupal.org/project/ip_geoloc
• https://www.drupal.org/project/ip2country
• https://www.drupal.org/project/hostip
• https://www.drupal.org/project/location

Module duplication and fragmentation is a huge problem on drupal.org and we prefer collaboration over competition. Unless you can argue that your module is unique and cannot be fitted into one of the efforts listed above, please open an issue in the most relevant issue queue to discuss what you need. You should also get in contact with the maintainer(s) to offer your help to move the project forward. If you cannot reach the maintainer(s) please follow the abandoned project process.

If that fails for whatever reason please get back to us and set this back to "needs review".

Git Clone Command

Your git clone command still refers to the "master" branch. Also, your git clone command is for you, and will not work for others.

Changing status.

@hexasoft, I appreciate you taking the time to explain in #6 why your location module is different from the others.

And while possible overlap of functionality may not be a blocking issue, we require as a minimum that users should be informed about possible functional overlap so that they can make the best choice when looking for a location module. Please take a moment and create a section with the heading "Similar projects and how they are different" on the project's project page where you:

1. acknowledges the existence of similar projects; and
2. briefly explain how they are different.

PS: Your git clone command still refers to the "master" branch. Also, your git clone command is for you, and will not work for others.

Your git command

git clone --branch master hexasoft@git.drupal.org:sandbox/hexasoft/2050979.git 

still refers to master and is your personal git command, not one usable by others.

Please change your git command to

git clone http://git.drupal.org/sandbox/hexasoft/2050979.git

• You have a lot of errors from Drupal coding standard validation.
  see: http://pareview.sh/pareview/httpgitdrupalorgsandboxhexasoft2050979git

please follow this https://www.drupal.org/coding-standards

@gisle
We have updated the description to acknowledge ourselves as from IP2Location and provided the details of the features that make us different from the other providers.

Have you? I am unable to find any mention of the other ip2location-projects and what makes you different on the the project page.

Just to spell it out: Your project page is still missing a section where you explain how your IP2location-project is different from all the other IP2location projects that exists.

We require as a minimum that users should be informed about possible functional overlap so that they can make the best choice when looking for a location module. Please take a moment and create a section on your project's project page with the heading "Similar projects and how they are different", where you:

1. acknowledges the existence of similar projects; and
2. briefly explain how they are different.

Please see this page for more information.

Updated issue summary.

@hexasoft, Thanks for your contributions.

Automated Review

Best practice issues identified by pareview.sh / drupalcs / coder.All are fine.
http://pareview.sh/pareview/httpgitdrupalorgsandboxhexasoft2050979git

Manual Review

Individual user account

Yes: Follows the guidelines for individual user accounts.

No duplication

May be: Please also specify the differences of the other modules with this module on this page.Does not cause module duplication and fragmentation.

Master Branch

Yes: Follows the guidelines for master branch.

Licensing

Yes: Follows the licensing requirements

3rd party code

Yes: Follows the guidelines for 3rd party code.

README.txt/README.md

No: Please udpate the Installation section in the Readme.txt and simply write Install as you would normally install a contributed drupal module. See:
https://drupal.org/documentation/install/modules-themes/modules-7
for further information. Follows the guidelines for in-project documentation and the README Template.

Code long/complex enough for review

Yes: Follows the guidelines for project length and complexity.

Secure code

Yes. If "no", list security issues identified.

Coding style & Drupal API usage

1. (*) Update the configure path in the iplocation.info file.
2. Use drupal_strtolower instead of strolower in function ip2location_fix_case. Same use drupal_strupper instead of strtoupper.
3. Use Module from the name of the module from ip2location.info file.
4. I found this function is not used anywhere ip2location_get_header($key) .Please unsed code.

This review uses the Project Application Review Template.

As I am not a git administrator, so I would recommend you, please help to review other project applications to get a review bonus. This will put you on the high priority list, then git administrators will take a look at your project right away :-)

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.