Most properties fail to return any data because the entity info for them incorrectly uses entity_metadata_entity_get_properties() and unless the property is called "url". I know the name of that function is very miss-leading and I would expect it to return the properties default verbatim value by default but that is not how it behaves.

Also the Entity definition references a non-existing function "fpp_entity_metadata_fpp_get_properties" in the property path. Seems that function got renamed to fieldable_panels_panes_metadata_fpp_get_properties.

CommentFileSizeAuthor
#1 fieldable_panels_panes-entity-api-broken-2280457.patch1.47 KBmagicmyth

Comments

magicmyth’s picture

magicmyth commented
StatusFileSize
new fieldable_panels_panes-entity-api-broken-2280457.patch1.47 KB
magicmyth’s picture

magicmyth commented

It might be worth considering in this issue. fieldable_panels_panes_metadata_fpp_get_properties() will return the base site path if the path is empty (the behaviour of url() if an empty string is passed.). E.g. "/". Should it maybe return nothing if the value matches $base_path?

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Active » Needs review

Thanks for the patch, I'll review it soon.

FYI when you upload a new patch you should also change the status to "Needs review", that will trigger the test bot to take a run through the code and also notify me (and other contributors) that there's some code to review.

magicmyth’s picture

magicmyth commented

Doh! Forgot to update the status. Thanks for still taking notice though :)

zambrey’s picture

zambrey commented

Thanks, the patch works fine.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs review » Fixed

Committed. Thanks.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.