Update Drupal.org's drush make for distro packaging so distros are not forced to nest contrib projects inside contrib projects

I don't fully understand what this issue is proposing to change.

The only "nesting" going on is either caused by:

A) The packaging script creating full tarballs which are supposed to be easy for end users to download and install without knowing about package management tools, running drush make themselves, etc. These are a whole "site in a tarball", including the distro, core, all modules/themes, just as a tarball, without git anywhere to be seen.

B) Distribution maintainers Doing It Wrong(tm). See #2153139: Unpublish Distributions with Forks of Core < 7.32

If a developer/contributor wants to do things with a more fancy workflow involving site repos and git sub(trees|module)s, they can/should run drush make themselves, can use whatever version of drush and its features they want. But our packaging script definitely isn't setting up git at all, so I don't see why we need to do this.

Can you please explain?

Thanks!
-Derek

Regardless, upgrading the drush version used for packaging distros is good to do. This should either be merged into #1854444: Upgrade drush used for distro packaging with drush make, or close that in favor of this issue since it has more recent information.

The next step will be updating our Puppet module that installs drush & other packaging requirements. We will want both installed in parallel, while we try out staging/dev.

class drupalpackaging {
  vcsrepo { "/var/www/drupal.org/tools/drush5":
    ensure => present,
    provider => git,
    source => 'http://git.drupal.org/project/drush.git',
    revision => '6f30fec6a8a3b2091228fd71d569879563aa6023',
  }

  vcsrepo { "/var/www/drupal.org/tools/drupalorg_drush":
    ensure => present,
    provider => git,
    source => 'http://git.drupal.org/project/drupalorg_drush.git',
    revision => 'cd474d2e64aad71dcb6f479f9b63a819611b2777',
  }

  vcsrepo { "/var/www/drupal.org/tools/drush_make":
    ensure => present,
    provider => git,
    source => 'http://git.drupal.org/project/drush_make.git',
    revision => 'a945642c5c48b759ae4a935a1b1cc0943ed720dc',
  }
}

Now that drush make files can be YML formatted, this is causing more friction for distribution maintainers.

I tested drupalorg_drush out with Drush 9 and managed to get tests passing without substantive code changes.

We’ve been using Drush 8.1.3 to build & deploy *.Drupal.org sites for a couple weeks and everything is working well. There were some minor changes in info file formatting, but nothing major.

The remaining work here is to get drush with drupalorg_drush set up in Puppet, alongside the old drush in case we have to switch back; then switch the packaging script to use the new path.

Finally going to do this.

All my testing shows this is ready to deploy, which should happen within the next hour.

Done - Drupal.org packaging now has Drush 8.1.12