One of the delay constraint test assertions fails on my system. I suspect it has passed only on Drupal.org due to two offsetting bugs. Will now test theory using testbot.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | 2282351-delay_constraint_test_fails-3.patch | 952 bytes | aohrvetpv |
| #1 | 2282351-delay_constraint_test_fails-1.patch | 937 bytes | aohrvetpv |
Comments
Comment #1
aohrvetpv commentedComment #3
aohrvetpv commentedPrior failure was expected. If hypothesis is correct, this patch should pass testbot.
Comment #4
aohrvetpv commentedThe second part of the delay constraint test attempts to evaluate the constraint after the specified delay (1s) has elapsed. The constraint should return TRUE.
The test was wrongly asserting FALSE. However, on a fast enough system (e.g., testbot), the 1s delay would not elapse, and the constraint would evaluate FALSE, causing the test to pass. On a slower system (e.g., mine), the delay would elapse as intended, the constraint would return TRUE, and the test would fail.
The patch in #3 fixes the assertion and adds a sleep() to ensure the delay is always exceeded, no matter the speed of the testing system.
Comment #6
aohrvetpv commented