One of the delay constraint test assertions fails on my system. I suspect it has passed only on Drupal.org due to two offsetting bugs. Will now test theory using testbot.

Comments

aohrvetpv’s picture

Status: Active » Needs review
StatusFileSize
new937 bytes

Status: Needs review » Needs work

The last submitted patch, 1: 2282351-delay_constraint_test_fails-1.patch, failed testing.

aohrvetpv’s picture

Status: Needs work » Needs review
StatusFileSize
new952 bytes

Prior failure was expected. If hypothesis is correct, this patch should pass testbot.

aohrvetpv’s picture

The second part of the delay constraint test attempts to evaluate the constraint after the specified delay (1s) has elapsed. The constraint should return TRUE.

The test was wrongly asserting FALSE. However, on a fast enough system (e.g., testbot), the 1s delay would not elapse, and the constraint would evaluate FALSE, causing the test to pass. On a slower system (e.g., mine), the delay would elapse as intended, the constraint would return TRUE, and the test would fail.

The patch in #3 fixes the assertion and adds a sleep() to ensure the delay is always exceeded, no matter the speed of the testing system.

  • Commit daae695 on 7.x-2.x by AohRveTPV:
    Issue #2282351 by AohRveTPV: Delay constraint test logic reversed.
    
aohrvetpv’s picture

Status: Needs review » Fixed

  • Commit 2567a35 on 7.x-2.x by AohRveTPV:
    Issue #2282351 by AohRveTPV: Delay constraint test logic reversed.
    

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.