Closed (fixed)
Project:
Password Policy
Version:
7.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
8 Jun 2014 at 07:22 UTC
Updated:
22 Jun 2014 at 17:30 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
aohrvetpv commentedComment #3
aohrvetpv commentedPrior failure was expected. If hypothesis is correct, this patch should pass testbot.
Comment #4
aohrvetpv commentedThe second part of the delay constraint test attempts to evaluate the constraint after the specified delay (1s) has elapsed. The constraint should return TRUE.
The test was wrongly asserting FALSE. However, on a fast enough system (e.g., testbot), the 1s delay would not elapse, and the constraint would evaluate FALSE, causing the test to pass. On a slower system (e.g., mine), the delay would elapse as intended, the constraint would return TRUE, and the test would fail.
The patch in #3 fixes the assertion and adds a sleep() to ensure the delay is always exceeded, no matter the speed of the testing system.
Comment #6
aohrvetpv commented