Similar to my previously posted issue #2270103: Make config property of 'Example Policy' more readable and patch ;

In module's test file, the config property is a serialized array and it is not very easy to read. Besides it doesn't even fit the coding standards of Drupal which recommends not to have lines longer than 80 chars.

I've attached a similar patch that makes it more readable. Please review.

CommentFileSizeAuthor
more_readable_config_property_in_test_file.patch2.24 KBey

Comments

aohrvetpv’s picture

aohrvetpv commented
Status: Needs review » Postponed

Thanks. If it's OK, before committing I would like to update the patch in #2145649-24: Simpletests for UI of password set and expiry to apply on top of this. There has been a Testbots problem (#2283765: Test usually fails on testbot, but always passes locally) that has been causing that patch to intermittently fail testing, and committing this patch would cause that patch not to apply, which could confuse the matter. If you want to update that patch to apply on top of yours it would be much appreciated, otherwise I will try to do it later.

aohrvetpv’s picture

aohrvetpv commented
Assigned: ey » aohrvetpv
Status: Postponed » Active

Working on it now.

  • Commit 67a3326 on 7.x-2.x by AohRveTPV: 
    Issue #2285687 by pc-wurm: Make config property in test file more...
aohrvetpv’s picture

aohrvetpv commented
Status: Active » Fixed

Committed/pushed. Thanks again.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

aohrvetpv’s picture

aohrvetpv commented

Sorry I didn't give proper credit for this commit. At the time I did not realize you had to use the --author parameter.

ey’s picture

ey commented

@AohRveTPV no problems :)