Check if its possible to use dependency injection instead of using \Drupal::formBuilder() directly. This is used in several places in EntityEmbedDialog. Use dependency injection in all such places, if possible.

Comments

cs_shadow’s picture

cs_shadow commented
Status: Active » Needs review

Indeed its pretty much possible. Here's the PR: https://github.com/drupal-media/entity_embed/pull/53

slashrsm’s picture

slashrsm commented
Status: Needs review » Fixed

Merged.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.