hi,
after updating to 1.7 version by drush upc, i had this warning :
Division by zero password_policy.install:360

actually 

$sandbox['password_count'] = db_query("SELECT COUNT(pid) FROM {password_policy_history}")->fetchField();

is returning 0 as there is no password in the database yet for me.

so 

      $sandbox['#finished'] = $sandbox['password_from'] / $sandbox['password_count'];

is currenty deviding by 0

CommentFileSizeAuthor
#7 password_policy-division_by_zero-2289023-7.patch568 bytesaohrvetpv
#5 password_policy-division_by_zero-2289023-5.patch563 bytesaohrvetpv
#3 password_policy-division_by_zero-2289023-3.patch562 bytesaohrvetpv
#1 password_policy-division_by_zeor-2289023-1.patch3.34 KBizus

Comments

izus’s picture

izus commented
Status: Active » Needs review
StatusFileSize
new password_policy-division_by_zeor-2289023-1.patch3.34 KB

hi,
here is a patch for this.
Thanks

aohrvetpv’s picture

aohrvetpv commented
Priority: Normal » Major

Thanks for reporting it and for the patch.

I don't think there are any problems caused by the update failing, but we should probably do another release soon to include this fix.

aohrvetpv’s picture

aohrvetpv commented
StatusFileSize
new password_policy-division_by_zero-2289023-3.patch562 bytes

Here is a patch that fixes it in another way. I prefer this way because it only changes a line and keeps the update code easy to diff against user_update_7000(). Also I think patch in #1 might perform a query for each execution of password_policy_update_7102() (it is a batch API function so it gets invoked multiple times).

aohrvetpv’s picture

aohrvetpv commented
Status: Needs review » Needs work

Whoops, that patch was wrong...

aohrvetpv’s picture

aohrvetpv commented
Status: Needs work » Needs review
StatusFileSize
new password_policy-division_by_zero-2289023-5.patch563 bytes

New patch for 7.x-1.x. 7.x-2.0-alpha2 also has this bug, and the same change should fix it.

aohrvetpv’s picture

aohrvetpv commented

Again the patch is wrong...

aohrvetpv’s picture

aohrvetpv commented
StatusFileSize
new password_policy-division_by_zero-2289023-7.patch568 bytes

OK, this one is better tested. I tested two cases:
1. No entries in {password_policy_history} => no division by zero error
2. Enough entries in {password_policy_history} to require multiple batch chunks => all password hashes converted

  • Commit 1ce72bb on 7.x-1.x by AohRveTPV: 
    Issue #2289023 by izus, AohRveTPV: password_policy.install division by...
  • Commit ec431e5 on 7.x-2.x by AohRveTPV:
    Issue #2289023 by izus, AohRveTPV: password_policy.install division by...
aohrvetpv’s picture

aohrvetpv commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.