[D7] QuickAdmin

Your project fails automated review. Please correct that.
http://pareview.sh/pareview/httpgitdrupalorgsandboxdelzhand2295077git

in quickadmin_menu(), your item should really have a type of MENU_CALLBACK, since that's what it's supposed to be.

in quickadmin_page_alter(), you should verify that the library was found before loading your javascript which requires it.

In quickadmin_go, you assume there is some $item from the form_state, which you shouldn't.

On line 101, you do this:

if (libraries_load('mousetrap')) {

I am fairly certain that this will evaluate to true under all circumstances.

It is better to do something like this:

$my_library = libraries_load('mousetrap');
if($my_library['loaded'] !== FALSE) {

On 111, you're using HTML in t(), you shouldn't. I understand you want to emphasize this, so you should use a %variable, this will automatically generate emphasized text. See https://api.drupal.org/api/drupal/includes%21bootstrap.inc/function/form...

The readme states that mac users need to use the cmd+m keys, but this is not correct... I'm using mavericks and cmd+m just hides my browser window; I have to use ctrl+m for the quickadmin search box to appear.

Once I get the box to appear, it immediately disappears! It actually looks like the entire page is being reloaded. (I'm using chrome btw, in case that matters)

Also, much more minor issue... you should change the readme to tell people to get the entire mousetrap library from the git repository... I couldn't even get the library to load initially because I had just created the directory structure and added the 2 .min.js files, but it appears to need more than that. the library was undetected until I had the full repository uploaded to my libraries directory.

You might also want to check out the readme template here

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Hello delzhand,

I reviewed your project , i really like your module.

Here is the some points regarding with this project

1. Here is your submit function

  $item = $form_state['values']['quickadmin_search'];
  if (isset($item)) {
    $result = db_select('menu_router', 'mr')
      ->fields('mr', array('path'))
      ->condition('mr.path', $item)
      ->execute()
      ->fetchAssoc();
    drupal_goto($result['path']);
  }
}

please use isset in $form_state and use some drupal api for some checks like this

global $base_url;

  if (isset($form_state['values']['quickadmin_search'])) {
    $item = $form_state['values']['quickadmin_search'];
    $item = valid_url($item) ? (drupal_valid_path($item) ? $item : $base_url) :$base_url; 

    if ($item == $base_url) {
      drupal_goto($item);
    }

    $result = db_select('menu_router', 'mr')
      ->fields('mr', array('path'))
      ->condition('mr.path', $item)
      ->execute()
      ->fetchAssoc();

    drupal_goto($result['path']);

  }

2. Its not a good point you may leave this point.

drupal_add_js(drupal_get_path('module', 'quickadmin') . '/quickadmin.js');

First get path and store value in variable and then use use that variable, It increase the readability of code

$quickadmin_module_path = drupal_get_path('module', 'quickadmin');
drupal_add_js( $quickadmin_module_path . '/quickadmin.js');

It is a good practice that we use #prefix first then #markup and then #suffix

$page['page_top']['quickadmin'] = array(
'#markup' => drupal_render($form),
'#prefix' => '

',
);

Here you may write this code in this order

$page['page_top']['quickadmin'] = array(
'#prefix' => '

',
);

3. If it is possible Please try to write code so that shortcut key may be configured, user can chose their own short key.

I'd like this module available in full project.

i have test your module manually and found some issues.
1. your module is not working at admin overlay pages.
2. when suggestions are loaded and click on any suggestion nothing happened and form disappear.
unless i put complete url and press enter.

3. this is not a good behavior your module is installed without having your required library.
you have to stop this behavior by using hook_requirements() function.

4. you are not tells people about your requirements in you project page also not at this application page. unless read you modules read me file.

5.a warring message is appear when module is installed but module is installed without required library.
add a link to you library in this message.

hi
here is a example that suite your project
http://drupalcontrib.org/api/drupal/contributions!colorbox!colorbox.inst...

also see this there is 72 hook_requirments() examples here must be one for you.
http://drupalcontrib.org/api/drupal/drupal!modules!system!system.api.php...

thanks

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.