Closed (fixed)
Project:
Panelizer (obsolete)
Version:
7.x-3.x-dev
Component:
Code
Priority:
Major
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
14 Jul 2014 at 14:41 UTC
Updated:
22 Sep 2014 at 06:20 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
damienmckennaInitial patch. The rest of the system needs refactoring accordingly as the API was extended with some new functions.
Comment #2
damienmckennaThis patch causes problems when an entity is first Panelized, it makes it impossible to get to the page to modify the new display as it doesn't really exist yet.
Comment #3
damienmckennaThere's a problem with the static caching that caused #2305681: Panelizer display used in Views preview, not on actual page output to occur.
Comment #4
andrew m riley commentedThe static check was causing the additional defaults to never load (in my case it was loading the main page panelizer defaults for the page bundle.) I'm attaching a patch that moves the static to a privately scoped variable for the object that still allows for caching but allows for additional defaults to be loaded.
Comment #5
damienmckennaThanks for fixing my facepalm-worthy bug.
Reviewing the updated code, is there any reason to use the $entity_type in the keys for $this->displays_loaded, especially when get_default_panelizer_objects() is passed the bundle name? Need to test this.
Comment #6
damienmckennaFixes a problem where entities were not being displayed if the default was changed and the ':default' display didn't exist or was disabled.
Comment #7
damienmckennaCommitted. Thanks for the help, Andrew!
Comment #9
damienmckennaA follow-up to resolve an issue during hook_entity_load().
Comment #10
damienmckennaCommitted. Again.