When a non-admin user with "create fieldable panels pane" permission, and not "administer fieldable panels panes" permission goes to /admin/structure/fieldable-panels-panes/manage/fieldable_panels_pane/add an error is thrown.
Notice: Trying to get property of non-object in PanelsPaneController->access() (line 73 of C:\www\sandbox\sites\all\modules\fieldable_panels_panes\includes\PanelsPaneController.class.php).
This was introduced with commit d29b81b http://cgit.drupalcode.org/fieldable_panels_panes/commit/?id=d29b81b
to resolve issues https://www.drupal.org/node/2283165 and https://www.drupal.org/node/2225125
$entity will be a string when fieldable_panels_panes_access() is called from fieldable_panels_panes_content_type_create_access() or from any menu item using %fieldable_panels_pane_type since fieldable_panels_pane_type_load() returns a string.
One approach would be to use the format of the Entity API's access callback functions where you have a fourth parameter of $entity_type, but I've gone for the node_node_access() approach instead and test for $entity being a string to then be able to set an $entity_type variable.
| Comment | File | Size | Author |
|---|---|---|---|
| #9 | fieldable_panels_panes-n2302931-9.patch | 2.05 KB | damienmckenna |
Comments
Comment #1
Adrian Richardson commentedComment #2
Adrian Richardson commentedComment #3
marty2081 commentedThis patch works and needs to be comitted as soon as possible since this breaks basic functionality.
In our case we had issues with the Panels In Place Editor not showing any fieldable panels panes in the add pane modal when the user doest not have the 'administer fiedable panels panes' permission. It turns out to be the same issue as described in this issue description. The patch fixes the case that the $entity variable is a string containing the entity type instead of an object.
Comment #4
Helrunar commentedI can confirm that the patch is needed and working.
Comment #5
chris burge commentedI can confirm the error reported by @Adrian Richardson. Patch #1 resolves the issue.
Comment #6
damienmckennaThank you for the patch and for reviewing it. I've got a small request - you should only use a variable named "$entity_type" when talking about different types of entities, so could you please update the patch to use the correct variable name "$bundle"? Thanks.
Comment #7
damienmckennaA minor tweak to change $entity_type to $bundle, etc.
Comment #9
damienmckennaLeft in a small syntax bug.
Comment #10
damienmckennaCommitted. Thanks Adrian!