When creating a new revision, if the display is customized, i.e. 'did' != 0, it should always create a new display record. This will avoid problems e.g. reverting a scenario and then customizing the display without creating a new revision would in fact customize the previous revision's display along with the current revision's display too.

CommentFileSizeAuthor
#4 panelizer-n2354437-4.patch3.6 KBdamienmckenna
#3 panelizer-n2354437-3.patch3.23 KBdamienmckenna
#1 panelizer-n2354437-1.patch1.27 KBdamienmckenna

Comments

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Active » Needs review
StatusFileSize
new panelizer-n2354437-1.patch1.27 KB

This changes revision creation so it sets $panelizer->display_is_modified, which then triggers a new display be created.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs review » Needs work

This needs an update script to fix existing records.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
StatusFileSize
new panelizer-n2354437-3.patch3.23 KB

Update script included.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
StatusFileSize
new panelizer-n2354437-4.patch3.6 KB

This version will clear the caches of any entities which were modified.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs work » Needs review
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Related issues: +#2082841: Reset to defaults should call entity's update hooks

This issue is useful too: #2082841: Reset to defaults should call entity's update hooks

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs review » Fixed

Committed.

  • DamienMcKenna committed 3e6aaa4 on 7.x-3.x 
    Issue #2354437 by DamienMcKenna: Always save a new display record when a...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.