The Encryption options take up quite some space on the node/add/site form.

It would be nice if most of the options were hidden until 'Enabled' is selected.

Screenshot of the current situation

CommentFileSizeAuthor
#7 refactor_ssl_forms-2407885-7.patch1.51 KBhelmo
create_site_ssl_form.png77.52 KBhelmo

Comments

helmo’s picture

helmo commented

Two related errors...

On site node edit:
Illegal choice 0 in Encryption key element.

On a verify task:
WD node: PDOException: SQLSTATE[23000]: Integrity constraint violation: 1048 Column 'ssl_key' cannot be null: UPDATE {hosting_ssl_site} SET ssl_enabled=:db_update_placeholder_0, ssl_key=:db_update_placeholder_1 WHERE (vid = :db_condition_placeholder_0) ; Array ( [:db_update_placeholder_0] => 0 [:db_update_placeholder_1] => [:db_condition_placeholder_0] => 4234 ) in hosting_ssl_nodeapi_site_update() (line 288 of /data2/aegir/hostmaster-7.x-3.x-4/profiles/hostmaster/modules/contrib/hosting/web_server/ssl/hosting_ssl.nodeapi.inc).

  • helmo committed f557524 on 
    Issue #2407885: refactor SSL forms - hide other SSL fields when not...
helmo’s picture

helmo commented
Issue tags: +aegir-ssl
ergonlogic’s picture

ergonlogic
he/him
Primary language English
Location Montréal, Québec 🇨🇦
commented

I've moved SSL fields into a fieldset, so as not to have them always float to the top of the site form. Also, fields are dependant on the state of other fields, though this is possibly causing some issues with pre-populating the key name field with the site name.

helmo’s picture

helmo commented

The wrapper fieldset works OK.

About 'pre-populating the key name field with the site name.' it seems that hosting_ssl_hosting_site_options_alter() is not run.
If I add ?platform=136 (by clicking through a platform page) no platform is pre-selected.

  • helmo committed f557524 on 7.x-4.x 
    Issue #2407885: refactor SSL forms - hide other SSL fields when not...
helmo’s picture

helmo commented
Status: Active » Needs review
StatusFileSize
new refactor_ssl_forms-2407885-7.patch1.51 KB

This patch fixes the "Illegal choice 0 in Encryption key element."

gboudrias’s picture

gboudrias commented
Issue tags: +Aegir 3.1

I think we need the patch for 3.1.

gboudrias’s picture

gboudrias commented
Status: Needs review » Reviewed & tested by the community

Works great!

gboudrias’s picture

gboudrias commented
Status: Reviewed & tested by the community » Needs work

Needs rerolling after the "key disabled" fix.

gboudrias’s picture

gboudrias commented
Status: Needs work » Fixed

Rerolled and pushed to 7.x-3.x.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.