The Hosting Signup form currently fails to submit, resulting in a number of PHP Warnings/Notices and a PDOException related to the creation of the client. The issue is related to a number of checks on the values of variables which do not exist, or in the case of the $node->uname variable, it should actually check if it exists AND is not empty. I will attach a patch shortly that fixes these issues.

Warning: Missing argument 2 for node_validate(), called in /var/www/html/profiles/hostmaster/modules/aegir/hosting/signup/hosting_signup.module on line 106 and defined in node_validate() (line 1011 of /var/www/html/modules/node/node.module).
Warning: Missing argument 3 for node_validate(), called in /var/www/html/profiles/hostmaster/modules/aegir/hosting/signup/hosting_signup.module on line 106 and defined in node_validate() (line 1011 of /var/www/html/modules/node/node.module).
Notice: Undefined variable: form in node_validate() (line 1035 of /var/www/html/modules/node/node.module).
Notice: Undefined property: stdClass::$nid in hosting_client_validate() (line 322 of /var/www/html/profiles/hostmaster/modules/aegir/hosting/client/hosting_client.module).
Notice: Undefined variable: form in node_validate() (line 1039 of /var/www/html/modules/node/node.module).
Warning: Missing argument 2 for node_validate(), called in /var/www/html/profiles/hostmaster/modules/aegir/hosting/signup/hosting_signup.module on line 110 and defined in node_validate() (line 1011 of /var/www/html/modules/node/node.module).
Warning: Missing argument 3 for node_validate(), called in /var/www/html/profiles/hostmaster/modules/aegir/hosting/signup/hosting_signup.module on line 110 and defined in node_validate() (line 1011 of /var/www/html/modules/node/node.module).
Notice: Undefined variable: form_state in node_validate() (line 1035 of /var/www/html/modules/node/node.module).
Notice: Undefined property: stdClass::$nid in hosting_site_validate() (line 376 of /var/www/html/profiles/hostmaster/modules/aegir/hosting/site/hosting_site.form.inc).
PDOException: SQLSTATE[23000]: Integrity constraint violation: 1062 Duplicate entry '' for key 'name': INSERT INTO {users} (uid, name, pass, mail, created, status) VALUES (:db_insert_placeholder_0, :db_insert_placeholder_1, :db_insert_placeholder_2, :db_insert_placeholder_3, :db_insert_placeholder_4, :db_insert_placeholder_5); Array ( [:db_insert_placeholder_0] => 12 [:db_insert_placeholder_1] => [:db_insert_placeholder_2] => $S$DqaAG88ibX4Y93HarFWxtMY5nmCIIukRTOD4Kg7VVcFk/Nbn68BU [:db_insert_placeholder_3] => email.address2@email.com [:db_insert_placeholder_4] => 1434534757 [:db_insert_placeholder_5] => 1 ) in drupal_write_record() (line 7308 of /var/www/html/includes/common.inc).

Comments

sdrycroft’s picture

Status: Active » Needs review
StatusFileSize
new2.69 KB

The attached patch fixes the above issue.

gboudrias’s picture

Issue tags: +Aegir 3.1
gboudrias’s picture

Status: Needs review » Reviewed & tested by the community

The page now submits but I still get the email error on submit:

Notice: Undefined property: stdClass::$email in hosting_signup_form_submit() (line 133 of /home/gboudrias/aegir/modules/hosting/signup/hosting_signup.module).

This could be a separate issue but it would be nice to fix it if you have an idea. I don't normally use the signup form.

gboudrias’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.