entity_get_bundles() is deprecated, so needs to be replaced.

CommentFileSizeAuthor
#8 2552131-8.patch2.61 KBgiancarlosotelo
#8 interdiff-7-8.txt889 bytesgiancarlosotelo
#7 interdiff-7.txt654 bytesjoshi.rohit100
#7 2552131-7.patch2.87 KBjoshi.rohit100
#2 flag-remove-entity_get_bundles-2552131-2.patch2.15 KBmarkpavlitski
Tag1 supports Drupal development!Tag1 logo

Comments

joachim created an issue. See original summary.

markpavlitski’s picture

markpavlitski CreditAttribution: markpavlitski at Investis Digital commented
Status: Active » Needs review
FileSize
flag-remove-entity_get_bundles-2552131-2.patch2.15 KB

Patch attached to replace entity_get_bundles() with \Drupal::entityManager()->getBundleInfo().

Status: Needs review » Needs work

The last submitted patch, 2: flag-remove-entity_get_bundles-2552131-2.patch, failed testing.

Status: Needs work » Needs review

sdstyles queued 2: flag-remove-entity_get_bundles-2552131-2.patch for re-testing.

Status: Needs review » Needs work

The last submitted patch, 2: flag-remove-entity_get_bundles-2552131-2.patch, failed testing.

joachim’s picture

joachim CreditAttribution: joachim commented

I think our tests have been broken by a change in core...

joshi.rohit100’s picture

joshi.rohit100
he/him
Primary language Hindi
Location Delhi, India
CreditAttribution: joshi.rohit100 commented
Status: Needs work » Needs review
FileSize
2552131-7.patch2.87 KB
interdiff-7.txt654 bytes

Here is why test failing

giancarlosotelo’s picture

giancarlosotelo CreditAttribution: giancarlosotelo at MD Systems GmbH commented
FileSize
interdiff-7-8.txt889 bytes
2552131-8.patch2.61 KB

I don't think is the best solution.

We are testing that we have the manage fields tab so because of this change in core #507488: Convert page elements (local tasks, actions) into blocks we should add a block of tasks to the test to assert what we want.

joachim’s picture

joachim CreditAttribution: joachim commented
Status: Needs review » Needs work

Agreed -- though could you post the fix to the test in a new issue please? It's not related to the change we're making here.

giancarlosotelo’s picture

giancarlosotelo CreditAttribution: giancarlosotelo at MD Systems GmbH commented

Created #2561867: Test broken due to recent core change with tasks and actions blocks

markpavlitski’s picture

markpavlitski CreditAttribution: markpavlitski at Investis Digital commented
Status: Needs work » Needs review

Marking back as needs review for the patch in #2.

giancarlosotelo queued 2: flag-remove-entity_get_bundles-2552131-2.patch for re-testing.

joachim’s picture

joachim CreditAttribution: joachim commented
Status: Needs review » Fixed

Thanks everyone! Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.