CommentFileSizeAuthor
#14 2558243-captcha-14.patch6.6 KBBerdir
#7 2558243-captcha-7-interdiff.txt957 bytesBerdir
#7 2558243-captcha-7.patch14.03 KBBerdir
#5 2558243-captcha-5.patch12.76 KBBerdir
#2 2558243-captcha-2.patch12.78 KBtim.plunkett
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

tim.plunkett created an issue. See original summary.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett at Acquia commented
Status: Active » Needs review
FileSize
2558243-captcha-2.patch12.78 KB
Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented

I think a few comments from the github repo haven't been synced back which changed some of those functions, so this won't apply anymore after that, but should be relatively easy to reroll.

hass’s picture

hass CreditAttribution: hass commented
Status: Needs review » Needs work

There is a hunk. The patch does not apply.

Without this patch captcha is no longer shown on a page, but with the patch it is.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Priority: Normal » Critical
Status: Needs work » Needs review
FileSize
2558243-captcha-5.patch12.76 KB

Reroll, the module is completely broken right now, making this a critical.

Status: Needs review » Needs work

The last submitted patch, 5: 2558243-captcha-5.patch, failed testing.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Status: Needs work » Needs review
FileSize
2558243-captcha-7.patch14.03 KB
2558243-captcha-7-interdiff.txt957 bytes

Those test fails are not related and never worked on d.o, but lets fix them anyway while we're at it.

wundo’s picture

wundo CreditAttribution: wundo at Chuva Inc. for Chuva Inc. commented
Status: Needs review » Fixed

Thanks, committed! :)

  • wundo committed 09cb482 on 8.x-1.x authored by Berdir 
    Issue #2558243 by Berdir, tim.plunkett: Use a FormElement plugin instead...
LKS90’s picture

LKS90 CreditAttribution: LKS90 commented
Status: Fixed » Needs work

The actual FormElement is missing from the commit? See here, there should be a folder called Element with the Captcha.php inside.

Also, where is development done now? Github or d.o? There is no real feedback on github, so I assume it's here?

hass’s picture

hass CreditAttribution: hass commented

Ah, that's why all the tests are broken.

hass’s picture

hass CreditAttribution: hass commented
Issue summary: View changes
Related issues: +#2565255: captcha_set_form_id_setting() or forms are broken

Than this may be a duplicate.

hass’s picture

hass CreditAttribution: hass commented
Issue summary: View changes
Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Status: Needs work » Reviewed & tested by the community
FileSize
2558243-captcha-14.patch6.6 KB

Patch with just the new file.

  • wundo committed 5b5df83 on 8.x-1.x authored by Berdir 
    Issue #2558243 by Berdir, tim.plunkett, hass, wundo: Use a FormElement...
wundo’s picture

wundo CreditAttribution: wundo at Chuva Inc. for Chuva Inc. commented
Status: Reviewed & tested by the community » Fixed

Committed!

The last submitted patch, 2: 2558243-captcha-2.patch, failed testing.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.