The output of XBBCodeFilter needs to be tested - especially with some very quirky / invalid markup, and insane escape sequences in the tag element itself.

Eg.

[foobar foo=bar\ bar bar=foo\\\ f"oo foobar="foo'\ \\\"" barfoo='foobar\ \'\\\\\"']

Should (if I didn't miscount the backslashes) yield attributes represented by the following PHP literal:

[
    'foo' => "bar bar",
    'bar' => 'foo\\\\ f"oo',
    'foobar' => "foo'\\ \\\"",
    'barfoo' => 'foobar\\ \'\\\\\\"',
]

Comments

cburschka created an issue. See original summary.

cburschka’s picture

Status: Active » Needs review
StatusFileSize
new3.49 KB

Test for the attribute values.

This should fail, because the attribute value parsing has a bug whose patch hasn't yet been published.

cburschka’s picture

Status: Needs review » Needs work

The one time I want a test to fail... :-/

Hm.

It's not actually running the new test case. This seems weird.

cburschka’s picture

Oh well. I guess that means we need to push it to run the test - after first pushing the fix.

  • cburschka committed 2c9aa73 on 8.x-3.x
    Issue #2630676: Test attribute parsing.
    
    Test the parsing of attribute...
cburschka’s picture

Status: Needs work » Fixed
cburschka’s picture

Status: Fixed » Active

...oh wait, that's just one of the tests.

cburschka’s picture

Status: Active » Needs review
StatusFileSize
new1.75 KB

This should definitely fail, because the test hits two known bugs (the one in #263422: Add a "Continue Shopping" button to my cart? and a regex-regression).

cburschka’s picture

I guess the testbot is unable to see tests added by a patch or something.

  • cburschka committed 8417418 on
    Issue #2630676: Test basic filter operation.
    
    Create a properly nested...
cburschka’s picture

StatusFileSize
new5.56 KB

More testing.

  • cburschka committed a1cea83 on 8.x-3.x
    Issue #2630676: Test template tags.
    
    This patch enables the template...
cburschka’s picture

Status: Needs review » Active

There's probably quite a bit more.

  • cburschka committed 2c9aa73 on 9.x-1.x
    Issue #2630676: Test attribute parsing.
    
    Test the parsing of attribute...
  • cburschka committed 8417418 on 9.x-1.x
    Issue #2630676: Test basic filter operation.
    
    Create a properly nested...
  • cburschka committed a1cea83 on 9.x-1.x
    Issue #2630676: Test template tags.
    
    This patch enables the template...
cburschka’s picture

Status: Active » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.