Conditions are not limited by available contexts.

This is actually a core bug and stems from the fact that the BlockForm asks for all conditions regardless of its ability to satisfy their contexts. Easily fixed though.

Eclipse

Also, this is an outright bug in 8.0.x and doesn't change apis or anything so I think this can be safely done in 8.0.x.

Eclipse

No comment on 8.0.x vs 8.1.x, just putting it in the right place.

Also, for anyone wondering where that value comes, it's in the same class:

core/modules/block/src/BlockForm.php
125:    $form_state->setTemporaryValue('gathered_contexts', $this->contextRepository->getAvailableContexts());

Note that there are really two things here.

First is the problem that ctools adds all those conditions that then show up even if context for them is missing. The patch above fixes that.

However, content types are still duplicated. Because ctools adds a second one, with a different name. Does the one in ctools offer any benefit over the one in core? I don't think so, so I think we should exclude that one from being defined in ctools?

Or ctools should override the node_type condition in favor of the generic one. The ctools one does actually have some additional functionality that tracks constraints based upon context. I'll look into it.

Eclipse

I'd apply the patch from 3.

Yes, that's exactly berdir's comment from 8.

Eclipse

For which he also already openend an issue for: #2669758: Switch bundle condition for nodes to node_type instead of entity_bundle:node. Patches welcome.

Will upload a patch with tests soon.

Tests added. This should make it fail.

This came up again in #2811519: Blocks do not appear after being placed with the Rules module enabled (or other missing schemata for Condition plugins).

1. +++ b/core/modules/block/src/Tests/Views/DisplayBlockTest.php
   @@ -232,6 +232,11 @@ public function testViewsBlockForm() {
   +
   +    // Tests conditions with no existing context are not displayed.
   +    $this->drupalGet('admin/structure/block/add/views_block:test_view_block-block_1/' . $default_theme);
   

   Tests that conditions...

   no existing => missing.

   Why is this in a views tests? Should be in one of the tests in block.module IMHO.

2. +++ b/core/modules/system/tests/modules/condition_test/src/Plugin/Condition/ConditionTestNoExistingType.php
   @@ -0,0 +1,34 @@
   +    return $this->t('Condition with no existing context.');
   

   Condition that requires a non-existent context.

Changes made based on comment above.

That works for me.

Removed the needs screenshots tag, I think it is pretty obvious. Having ctools enabled adds a bunch of additional vertical tabs that actually don't work. This patch hides those that wouldn't work because nobody provides a vocabulary, a block_content or whatever to get the bundle from. Note that there are still two content type conditions, that we can't fix in core as ctools adds a duplicate and it has context.

That means we need to fix that in ctools, not in core.

Committed/pushed to 8.3.x and cherry-picked to 8.2.x, thanks!

Cherry-picked ++

I installed the 3.0 version, assuming this issue had been resolved. It is still showing the extra content types vertical tab in blocks.

I am on 8.3.3. My friends are on 8.3.4. We each see it.

Yes, because both are content type, and there is a content available. What this fixed is that it also shows vocabulary, block content type, and many other vertical tabs.

This is something that only ctools module can solve, as it defines a second condition with a different name. Or when it moves to core, in #1932810: Add entity bundles condition plugin for entities with bundles.