D7 link field instance settings not migrating

This should be done in \Drupal\link\Plugin\migrate\cckfield\LinkField but that would be blocked on #2631736: Cckfield Plugins must distinguish core versions

Happy with the current approach for now if we can add some tests?

This needs looking at again now that #2631736: Cckfield Plugins must distinguish core versions is in.

+++ b/core/modules/field/tests/src/Kernel/Migrate/d7/MigrateFieldInstanceTest.php
@@ -131,4 +131,10 @@ public function testFieldInstances() {
+  public function testLinkFieldInstances() {
+    /** @var \Drupal\field\FieldConfigInterface $field */
+    $field = FieldConfig::load('node.test_content_type.field_link');
+    $this->assertEquals(1, $field->getSetting('title'));
+  }

I'd prefer if these assertions were part of the main test method -- otherwise it's going to actually do the entire setup and execute all migrations again for this method.

Let's also use assertSame() here, since it's more precise (if the migration set the title setting to TRUE, this assertion would still pass even though the actual data would be wrong). Additionally, I'd prefer if we could assert against an actual class constant, if there is one, rather than a numeric value.

Beyond these concerns, I think this looks good. RTBC one the changes are made and tests are passing.

I assume Drupal CI will pass this, so RTBC from me.

+++ b/core/modules/link/src/Plugin/migrate/cckfield/d7/LinkField.php
@@ -27,4 +28,21 @@ public function getFieldWidgetMap() {
+    $process[0] = [

Why the [0] here?

+++ b/core/modules/field/tests/src/Kernel/Migrate/d7/MigrateFieldInstanceTest.php
@@ -131,6 +131,9 @@ public function testFieldInstances() {
+    $this->assertSame(DRUPAL_OPTIONAL, $field->getSetting('title'));

+++ b/core/modules/link/src/Plugin/migrate/cckfield/d7/LinkField.php
@@ -27,4 +28,21 @@ public function getFieldWidgetMap() {
+        'disabled' => DRUPAL_DISABLED,
+        'optional' => DRUPAL_OPTIONAL,
+        'required' => DRUPAL_REQUIRED,

It'd be great to have test coverage of all of the values.

Looks good!

Committed and pushed 057d3dc to 8.3.x and 497d2aa to 8.2.x. Thanks!