Adding to cart on PHP7 throws notice error

Looks good, confirmed same fix works locally. Setting to needs review to trigger testbot

Oh, patch wasn't in comment, won't trigger, uploading just to trigger, no changes.

Patch was not made relative and didn't apply, rerolled with proper paths

The 2 fails in PHP7 are from ctools and are fixed in the dev release of ctools

Thanks guys! Committed.

Patch #5 works for me.

Excellent. Thank you, smccabe

Any idea when this will be released?

EDIT: nevermind, I got my dates mixed up.

Yeah, this doesn't even seem to have appeared in the dev release? Strange.

This is not fixed. I just did a clean install and ran into this error when trying to enable the cart module. I had to implement the fix myself.

There is no stable version with this fix. You will have to use a dev version until 1.14 is released

This fix has still not been added to the current stable release.

Thank you. The patch worked for me.

Sorry, i ve the same problem - how can i add this patch?

At Line # 1344 changed it to:

$tmp_line_item = clone($line_item);
drupal_alter('commerce_cart_product_comparison_properties', $comparison_properties, $tmp_line_item);

that seemed to make the error go away.

as seen here:

Notice: Only variables should be passed by reference in commerce_cart_product_add()

Patch works for me, is simple, and makes sense.

9 months still not in stable release...

Hi,

The patch works for me.

Thank you,

confirmed; altering line 1344 to

$tmp_line_item = clone($line_item);
drupal_alter('commerce_cart_product_comparison_properties', $comparison_properties, $tmp_line_item);

***
issue began to occur only after upgrading from PHP 7.0 to the latest PHP 7.1 and then having run cron on the drupal instance, commerce cart module had been running OK with PHP 7.0 ;
making the changes allowed me to run commerce cart with PHP 7.1

I can confirm patch #5 is working. (tested on PHP 7.1.2)
Can a new 7.x-1.x version be created, please?

Patch #5 worked for me as well. Any word on when we'll get a stable release?

patch #5 worked. A release would be appreciated.

Thanks smccabe

Patch #5 Worked. I had applied this patch and work for me.

Tested on PHP 7.1, D7 + Commerce.
Was an error on commerce_cart, and patch#5 worked for me, thanx.

Patch #5 also worked for me. Whats taking so long on the stable release?

In short: #2697017: Revert the EntityFieldQuery based product matcher and arbitrary options list limit

Thanks smccabe

Patch #5 Works for me.

Same error here, the patch works for me. Thanks!

Many thx - #5 helped fix my problem - error gone now!

#5 worked for me. Thank you.

#5 solve my problem too

Hi @rszrama,

I'm upgrading a website to PHP7.x (Drupal 7.59 and PHP 7.1) and updating commerce module from 7.x-1.13 to 7.x-1.14.

After updating the module, I've got a "FacesExtendableException: There is no method getElementName for this instance of the class RulesConditional. in /app/sites/all/modules/rules/includes/faces.inc:133" error and can't access rules and payment methods any more (WSOD).
Or when trying to clear caches.
Same happens using the latest 7.x-1.x-dev version.

If I rollback to version 7.x-1.13 and apply the patch #5 it works, but not on version 1.14 where the patch should be committed to.

Is it safe to stay in commerce 7.x-1.13 running PHP 7.1?
Any idea why the 7.x-1.14 version is not working?

Thanks.

Patch #5 Works for me too.

Thanks @smccabe

This patch appears to have included in commerce 1.15 but not included on the release notes.

@ jasonschweb: Yes, Patch#5 has already been included in commerce 7.x-1.15. It's missing in the release notes.

#5 works for me

#5 works for me