Mark Migrate Drupal UI as stable

I agree with the proposal in #7. Thanks @heddn!

Oops, I left my comment blank, sorry!

Updating the title based on #7.

#2953360: Experimental migrate_drupal_multilingual module has landed, which officially makes all translation migrations experimental, since they all depend on an experimental module. Once #2905736: Mark Migrate Drupal as stable is in, I am in favor of marking Migrate Drupal UI stable as well. It is well-tested and being used for successful (monolingual) migrations.

+1.

+1 for stability

Updated the IS

I'm pretty sure that was some kind of rando Nightwatch failure.

I think this test will fail until #2905736: Mark Migrate Drupal as stable is commited. The test seems to try to enable all non-experimental modules, but Migrate Druapl UI depends on Migrate Drupal which is no stable in this patch.

Just to make sure that the tests are green when both modules are stable.

It looks like we have to add the CSS of Migrate Drupal UI to the Stable theme. I never done this, but I looked at how it was done for content_moderation (#2897132: Mark Content Moderation module as stable).

The issue summary is currently talking about beta stability. If I'm not totally mistaken, the idea here is to declare Migrate Drupal UI as fully stable and not just beta so I updated the IS accordingly. The signoffs in #11 (phenaproxima), #12 (heddn) and #14 (maxocub) are all signing off for 'stable' and not just beta but if your signoffs were intended to be about beta stability and not full stability, yell loud and we can revert my IS updates.

Regarding the topic itself i.e. marking Migrate Drupal UI as fully stable. One of the beta criteria is that the module is considered API and feature complete. We still have this pending issue which is about how contrib modules can interact with Migrate Drupal UI, see #2936365: Migrate UI - allow modules to declare the state of their migrations

What do others think about this, should that land before we declare Migrate Drupal UI fully stable? That issue is currently categorized as 'Normal' and not 'Critical' but in my opinion it is quite important part of the Migrate Drupal UI. I'm OK that we add that later if that is acceptable in the release policy and if we jointly agree that it can be done after Migrate Drupal UI has been declared stable.

Cheers,
Markus

For me #2936365: Migrate UI - allow modules to declare the state of their migrations is a good addition we can make in a minor release, but shouldn't block this being marked stable.

+1 for declaring Migrate Drupal UI stable as per the previous comment #26.

@masipila, thanks for bringing up the point about #2936365: Migrate UI - allow modules to declare the state of their migrations. I'm glad that was addressed, although I'd like it's priority raised but that is a discussion for another time.

So, yes I agree that Migrate Drupal Ui can go stable.

Stability changes should at least be signed off by release managers, so I asked @catch to take a look again.

Yes happy for this to go stable, per #26 we can continue to make improvements in minor releases.

+++ b/core/themes/stable/css/migrate_drupal_ui/components/upgrade-analysis-report-tables.css
@@ -0,0 +1,23 @@
+.upgrade-analysis-report__status-icon--warning:before {
+  background-image: url(../../../../misc/icons/e29700/warning.svg);
+}
+.upgrade-analysis-report__status-icon--checked:before {
+  background-image: url(../../../../misc/icons/73b355/check.svg);
+}
+.upgrade-analysis-report__status-icon--error:before {
+  background-image: url(../../../../misc/icons/e32700/error.svg);
+}

This does not look like it would work, the module file it was copied from is in core/modules/migrate_drupal_ui/css/components/upgrade-analysis-report-tables.css, so going up directories up is the core/ directory which has misc in it.

However from core/themes/stable/css/migrate_drupal_ui/components/[].css it would be in /themes because this is one more directory deep.

Sorry about that. I manually tested this and it turns out that not only there was an extra "../", but the path was wrong. I look at the CSS for the Status report page and used the same paths and now the icons are correctly displayed.

I can RTBC this from my mobile if you provide screenshots demonstrating the fail and fix.

With patch from #23:

With patch from #32:

Boom! Just in time before the dinner. Now offline. :)

Committed/pushed to 8.7.x and cherry-picked to 8.6.x. Thanks!