When submitting a form which contains vertical tabs (such as adding node content), several of which have required fields, the last tab with an error state is given focus.

The first tab with an error state should be given focus.

CommentFileSizeAuthor
#2 2931402_focused_on_last_tab_instead_first.patch1008 bytesqzmenko

Comments

qzmenko created an issue. See original summary.

qzmenko’s picture

qzmenko
Primary language Russian
Location Novosibirsk
commented
Status: Active » Needs review
StatusFileSize
new 2931402_focused_on_last_tab_instead_first.patch1008 bytes

Patch attached

qzmenko’s picture

qzmenko
Primary language Russian
Location Novosibirsk
commented

Any reviews?

Vidushi Mehta’s picture

Vidushi Mehta commented

@qzmenko It would be good if you could attach a highlighting screenshot of the problem. Could not able to reproduce this.

Thanks

swentel’s picture

swentel commented

Will test in a bit, looks pretty cool!

nils.destoop’s picture

nils.destoop commented

Thx for the patch. I reviewed it, but I'm tweaking it a bit, as your version targets all tabs on a page. So it breaks when you have multiple tabs groups on a page.

  • zuuperman committed b2c43ca on 8.x-3.x 
    Issue #2931402 by qzmenko, zuuperman: Focused on last Vertical tab with...
nils.destoop’s picture

nils.destoop commented
Status: Needs review » Fixed

The fix is committed to dev.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.