Support from Acquia helps fund testing for Drupal Acquia logo

Comments

AdamGerthel created an issue. See original summary.

Berdir’s picture

Priority: Normal » Major
FileSize
1020 bytes

Seeing this too, this is a side effect of how the update process works and the variables are stored.

Workaround: On the settings page, make sure that "Do not store" is selected for the consent storage. For all translations.

The module uses a single huge array for all the variables, which forces it to write update functions to set the new keys (and there are a lot of them).

The problem is that on multilingual sites with variable translation, the whole array is considered a translation and then saved per language. Which means that the update functions only update the default translation and the translations have no key set.

I don't know why the approach with the single array was chosen but it's not going to be possible to change it now. My recommendation would be to put a fallback for required settings in eu_cookie_compliance_get_settings().

I'd say this is at least major.

svenryen’s picture

Thanks, @berdir. Patch looks okay, but I won't be able to do a full review for the first couple of weeks. I'll try to get this into the branch by end of June.

svenryen’s picture

Status: Active » Needs review

  • svenryen committed 53bb8a0 on 7.x-1.x authored by Berdir
    Issue #2976659 by Berdir, AdamGerthel: Function name must be a string
    
svenryen’s picture

Status: Needs review » Fixed

Fixed. Thanks!

  • svenryen committed 53bb8a0 on 7.x-2.x authored by Berdir
    Issue #2976659 by Berdir, AdamGerthel: Function name must be a string
    
  • svenryen committed 884a355 on 7.x-2.x
    Merge branch '7.x-1.x' into 7.x-2.x
    
    * 7.x-1.x:
    Issue #2975382 by...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

fox mulder’s picture

I can not find the above changes in the code of the latest stable or in the latest dev

and I experience the error while using the latest stable D7 version ( 7.x-1.32 )

svenryen’s picture

Status: Closed (fixed) » Active

Let me double check that. I had some issues while pasting patch files into phpstorm where not all lines got applied, so that could be the case.

svenryen’s picture

Status: Active » Postponed (maintainer needs more info)

@fox mulder, which version of php and drupal 7 are you using?
There shouldn't be any problem having a function name in a variable.

The code was updated/changed in #3064610: Undefined index notices on cache clear, but should still have the same effect.

svenryen’s picture

Can you run `drush vget eu_cookie_compliance` and paste the output here?

svenryen’s picture

Status: Postponed (maintainer needs more info) » Needs review
FileSize
560 bytes

@fox mulder - this is a stab in the dark, I'm guessing that somehow you have an empty value for consent_storage_method, not really sure why that's the case. Can you try this patch and let me know how it works? Please respond so that we can either try something else or commit this into the code base.

svenryen’s picture

Assigned: Unassigned » Neslee Canil Pinto
svenryen’s picture

Not sure if there are any test steps for this one, you can probably just do a review by reading the code and then just checking that we don't break any related functionality by applying this patch.

Neslee Canil Pinto’s picture

Status: Needs review » Fixed

Committed to dev branch. Thank you.

Neslee Canil Pinto’s picture

Assigned: Neslee Canil Pinto » Unassigned

  • svenryen committed 062e4fb on 7.x-2.x
    Merge branch '7.x-1.x' into 7.x-2.x
    
    * 7.x-1.x:
      Issue #3175031 by...
  • Neslee Canil Pinto committed 632975d on 7.x-2.x authored by svenryen
    Issue #2976659 by svenryen, Berdir, AdamGerthel: Function name must be a...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.