Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Problem/Motivation
This is a follow-up to #2964640: Provide a media type for remote video in Standard where we added the configuration for the remote video media type.
We missed adding a media library display for the "Remote video" type. So currently the actual video is displayed in the media library instead of a thumbnail.
Proposed resolution
- Add the display config.
Comment | File | Size | Author |
---|---|---|---|
#7 | media-overview.png | 694.54 KB | seanB |
#2 | 2982279.patch | 1.02 KB | chr.fritsch |
Comments
Comment #2
chr.fritschHere is the missing config
Comment #3
marcoscanoLooks good to me, but I wonder if
core/profiles/standard/tests/src/Functional/StandardTest
(or similar) shouldn't ensure that the types we ship in standard show up as expected in the media library?Comment #4
chr.fritschThese configs are currently part of the media_library module. I think it's because media_library is currently marked as experimental.
Comment #5
marcoscanoRight! Hadn't paid attention to that detail. I don't see why this shouldn't get in then.
Thanks!
Comment #6
phenaproximaEscalating to major. Will try to get eyes on this today.
Comment #7
seanBRTBC +1, just installed a fresh D8 and added some youtube video's.
Comment #8
alexpottI think whilst it is experimental it is okay to ship this without a test. Committed 257a881 and pushed to 8.6.x. Thanks!