During the development of the rules module I tested the "block user" action and noted, that in some cases it creates a garbled log message and a php notice.

Patch attached for HEAD and drupal 6.

CommentFileSizeAuthor
#4 drupal_action_user_block_d6-298698-v03.patch730 byteskars-t
#2 drupal_action_user_block_d6-298698-v02.patch730 byteskars-t
drupal_action_user_block_7.patch824 bytesfago
drupal_action_user_block_6.patch836 bytesfago

Comments

Anonymous’s picture

Anonymous (not verified) commented
Status: Needs review » Needs work

The last submitted patch failed testing.

kars-t’s picture

kars-t commented
Version: 7.x-dev » 6.x-dev
Status: Needs work » Needs review
StatusFileSize
new drupal_action_user_block_d6-298698-v02.patch730 bytes

For D7 this is fixed.

  $account = user_load($uid);
  watchdog('action', 'Blocked user %name.', array('%name' => $account->name));

I remade your patch for D6 but more like the D7 version that always reloads the user.

Status: Needs review » Needs work

The last submitted patch, drupal_action_user_block_d6-298698-v02.patch, failed testing.

kars-t’s picture

kars-t commented
Status: Needs work » Needs review
StatusFileSize
new drupal_action_user_block_d6-298698-v03.patch730 bytes

New version.

Status: Needs review » Needs work

The last submitted patch, drupal_action_user_block_d6-298698-v03.patch, failed testing.

kars-t’s picture

kars-t commented

I have created an infrastructure issue about this.

#968134: Testbot won't accept patches

Status: Needs work » Closed (outdated)

Automatically closed because Drupal 6 is no longer supported. If the issue verifiably applies to later versions, please reopen with details and update the version.