Early Bird Registration for DrupalCon Atlanta is now open! By registering during our Early Bird Registration window, you’ll save $100. This window ends on 19 January 2025 and will go by quickly, so don’t wait!
Problem/Motivation
setDatabaseDumpFiles
is called twice in \Drupal\FunctionalTests\Update\UpdatePathTestBase
meaning if you have methods that build upon each other like so:
/**
* {@inheritdoc}
*/
protected function setDatabaseDumpFiles() {
parent::setDatabaseDumpFiles();
$this->databaseDumpFiles[] = __DIR__ . '/../../fixtures/site-schema-fresh-install-expanded-test-content.php';
}
You will get a broken failing test.
Proposed resolution
Call the method once.
Remaining tasks
User interface changes
API changes
Data model changes
Comment | File | Size | Author |
---|---|---|---|
#7 | 3003401-7.patch | 2.18 KB | sam152 |
#2 | 3003401-2.patch | 2.06 KB | sam152 |
#2 | 3003401-2-TEST-ONLY.patch | 1.38 KB | sam152 |
Comments
Comment #2
sam152 CreditAttribution: sam152 as a volunteer and at PreviousNext commentedComment #6
pingwin4egReally simple. Could be even backported to 8.8.x. I'm marking it RTBC.
Comment #7
sam152 CreditAttribution: sam152 as a volunteer and at PreviousNext commentedReroll.
Comment #8
sam152 CreditAttribution: sam152 as a volunteer and at PreviousNext commentedBack to RTBC.
Comment #9
alexpottCommitted and pushed daab6ad7c8 to 9.0.x and bdce2114ab to 8.9.x. Thanks!
8.8.x is frozen so we can't backport there yet.
Comment #12
alexpottBackported this test only fix to 8.8.x