Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.For the AdminSettingsForm.php file.
First, these two fields $form['metatags']['ps_account'] and $form['metatags']['ps_config'] should not be required. I ran into the Where To Buy button not working when including these values and the documentation does not include these for the Where To Buy button.
Second, this $config->get('ps.js', '//cdn.pricespider.com/1/lib/ps-widget.js') does not set the default value to '//cdn.pricespider.com/1/lib/ps-widget.js'.
Lastly, some code styling fixes and add missing docblock.
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | pricespider-adminsettinfsform-2895595-5.patch | 2.99 KB | jasonawant |
Comments
Comment #2
kamkejj CreditAttribution: kamkejj at Nerdery commentedComment #3
kamkejj CreditAttribution: kamkejj at Nerdery commentedRename to .patch.
Comment #4
jasonawantComment #5
jasonawantb/c of misnamed config/insall directory in #3024782: Install file incorrectly named, the default value was not set. Re-rolling this patch to remove the default value set. The default value will now be installed with the module with fix in #3024782: Install file incorrectly named.
This is the same reason for the need to set the
$form['wtb']['wtb_uri'], so I'm going to revert that change. I also caught a typo.Comment #7
jasonawant