The existing version of hortizontal tabs styling in css could use improvements for consistency and aesthetic.

This is the current version

before

This is the proposed improvements

after

CommentFileSizeAuthor
#7 improve-horizontal-tabs-theming-3056732-7.patch1.39 KBvector_ray
#2 improve-horizontal-tabs-theming-3056732-0.patch1.74 KBvector_ray
after.png45.03 KBvector_ray
before.png45.94 KBvector_ray

Comments

vector_ray created an issue. See original summary.

vector_ray’s picture

vector_ray commented
StatusFileSize
new improve-horizontal-tabs-theming-3056732-0.patch1.74 KB

Here is the proposed patch for testing.

vector_ray’s picture

vector_ray commented
Assigned: vector_ray » Unassigned
Status: Active » Needs review
anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

Perfect and clear improvement. Let's push this forward!

Could you please check, if this applies against 8.x-3.x-dev?

ronaldmulero’s picture

ronaldmulero commented

field_group > 8.x-3.x … 1 > git apply improve-horizontal-tabs-theming-3056732-0.patch
error: patch failed: formatters/tabs/horizontal-tabs.css:6
error: formatters/tabs/horizontal-tabs.css: patch does not apply

swentel’s picture

swentel commented
Version: 8.x-1.x-dev » 8.x-3.x-dev
Status: Needs review » Needs work

That looks very nice indeed, anyone wants to re-roll this for the 8.x-3.x branch?

vector_ray’s picture

vector_ray commented
StatusFileSize
new improve-horizontal-tabs-theming-3056732-7.patch1.39 KB

He is a roll of the changes against the 3.x branch

  • zuuperman committed 5fcb74e on 8.x-3.x authored by vector_ray 
    Issue #3056732 by vector_ray, Anybody: Improve Horizontal Tab Styling
nils.destoop’s picture

nils.destoop commented
Status: Needs work » Fixed

Thx for the patch, looks idd better. Committed it to dev

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.