Create a keyboard shortcut to toggle access the search functionality

I don't use hotkeys, so I haven't thought of it. Can you give more detail of how you'd like it to behave? This is a major feature of the coffee module I know.

Yes, thanks for the explanation. Is it configurable in coffee? So you can switch hotkeys?

I was thinking about this same thing! If we build it in admin toolbar, I will no longer need to install Coffee on any projects. I will create a patch for it ASAP (I was going to do it this weekend, but then I fell sick 😷).

What do you think the shortcut should be? Shall I make it the same as it is in Coffee?

I think should be different from Coffee because maybe some users will continue using Coffee and if we use the same this can create problems.

Yes Adrian. I've thought about that. I might simply check if Coffee is enabled. If it is enabled, then I can setup a different shortcut. Also, I think I might just make it configurable.

Is better to keep this module without configuration, we can choose another combination, in my opinion, if we use the same as Coffee and a user has the two modules installed we may be forcing him to don't use a module he maybe loves to use.

Ok. Point noted.

As a side note, I always wanted to provide a configuration for this module to allow people to choose the toolbar color (: Do you think that's a good idea?

@jigarius the project owner @eme always says he wants to keep the module plug and play and without configuration. I think we need to see his opinion about the colors for the toolbar.

Ok. Then for now I'll just create a shortcut for the search and keep the frills and decorations for other issues. Thanks for the quick replies.

Hello !

I love the coffee module as well :-)

It may be interesting to include it into Admin toolbar, but woudn't be interesting to include the coffee module directly as a submodule and talking with the maintainer of the module ?

I talked to romainj the co-maintainer of the module who is refactoring a significant part of the module, so just to know that there will be some changes to come in the module code.

Here's the first iteration.

* Did some coding standard fixes.
* Created utility methods: isSearchVisible() and togglSearch()
* Create shortcut "Alt + S" / "Option + S" to toggle the search
* When the search is open, pressing "Escape" hides the search
* Installed Coffee and tested both of them to be working without conflict

Let me know if I missed something or if you have any suggestions (:

Works fine for me, @eme you're correct with the shortcut?

Excellent work. This is great. And the clean-up of coding standards is great. I just have one nit with the experience. When you press escape, it closes the toolbar, instead of returning you to where you were. So let's say you're on the manage tab, you press Alt + S and go to search, and for some reason you decide not to search, so you press Escape, right now, the entire toolbar closes. I think it should return you to your last tab, if available.

Suggested UX improvement when pressing escape:

If the toolbar was open when pressing Alt + S:

• The toolbar should not close.
• You should return to the tab you were on before pressing Alt + S

If the toolbar was closed when pressing Alt + S:

• The toolbar should close.

A nice observation. However, in my opinion that should be tackled in a different issue.

* The admin toolbar in general doesn't provide any nice way to know which tab is active.
* Also, using the shortcut to open the search bar is the equivalent of clicking on the "search" tab itself. And just like any other tabs, there is no way to press escape and jump back to the tab which was previously active (the other tabs don't behave that way either).
* Also, from a UX point of view, if a user is actually trying to activate the search, its highly probably that they'll type something and follow one of the autocomplete suggestions to land on a different page. And curiously, in this case, the admin toolbar currently lets the search tab open.

So, I believe that this ticket should probably restrict its scope to fixing the problem of having a shortcut for the search. We can however create another issue to improve:

* To maintain history of tabs clicked – at least when the user goes to the search tab.
* Then, whether the user collapses the search, presses escape or actually uses the search, the admin toolbar should restore the tab which was active right before the search tab was clicked.

If what I said above doesn't make sense and you believe that the UX improvement mentioned in comment 17 is absolutely necessary to be able to close this ticket, then please mark it as "Needs work" and I'll see if I can spend some time on it this weekend.

I think it's worth getting this in the way it is. Marking back to RTBC. The UX improvement isn't a must (#17) isn't a must. I can look into it as a follow up issue.

This is a great new feature.

Thanks to @all

Hi @jigarius can yo write a change notice for this new feature?

Alt+s (Option+s) happens to be a shortcut to type a Polish character of "ś". I imagine there are other languages with common problem. Can you suggest how to turn this off, please?

I think is better if we choose another different combination, can you propose another different shortcuts?

Can we move this to a follow-up?

#3087173: Allow shortcut key to be configurable

This did not apply for me. Perhaps it's outdated now? Any chance of this patch being updated?

That implementation was not ported to the 8.x-2.x version