This patch adds helpful trim() statements to the breadcrumb textareas.

Also, the same validate function has to name a field that is erroring. Without that, there is no error msg. Kinda hard to know what to fix.

CommentFileSizeAuthor
#2 custom_breadcrumbs-306637.patch1.25 KBTUc
#1 mw.patch1.04 KBmoshe weitzman
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

moshe weitzman’s picture

moshe weitzman CreditAttribution: moshe weitzman commented
FileSize
mw.patch1.04 KB

Ugh

TUc’s picture

TUc CreditAttribution: TUc commented
FileSize
custom_breadcrumbs-306637.patch1.25 KB

I made a patch for the same issue, but one that also saves the sanitized breadcrumb textareas. From a don't-mess-with-user-input perspective Moshe's approach looks better to me.

I build on his patch in order to set a field in the form_set_error(), choosing to error against the textarea with "missing" path or title strings.

thePanz’s picture

thePanz CreditAttribution: thePanz commented

Patch tested. Works fine on latest drupal--6-1-4 version.
Maybe you should add trim() check also before saving user text-areas.

Regards

MGN’s picture

MGN CreditAttribution: MGN commented

This patch also fixes the bug reported in #343608: Wrong implementation of form_set_error.

MGN’s picture

MGN CreditAttribution: MGN commented
Version: 6.x-1.3 » 6.x-1.x-dev
Status: Reviewed & tested by the community » Fixed

Committed to 6.x-1.x-dev

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.