Closed (fixed)
Project:
Field Group
Version:
8.x-3.x-dev
Component:
Code
Priority:
Major
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
5 Aug 2019 at 15:00 UTC
Updated:
16 Oct 2019 at 14:39 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
idebr commentedFixed the inner working of \Drupal\Tests\field_group\FunctionalJavascript\FieldGroupUiTest::testCreateAndEdit(), but it seems the last test failure is legit.
Comment #4
idebr commentedThe label element is being unset from format_settings since #2824350: missing UI for description text for field groups, so I removed these assertions from the test.
Comment #6
idebr commentedLet's go with the smallest possible change and leave the duplicate label schema for a follow-up.
Comment #7
andypostLooks good except last removed line in test, where formatter extended
Comment #8
idebr commented#7 Are you referring to these lines? The label property was removed in #2824350: missing UI for description text for field groups since its data was added twice in the configuration. This is what I referred to in #4:
field_group_group_save()Comment #9
andypostYes, missed to check that. Let's unblock testing!
Comment #10
chris matthews commented@maintainers, would it be possible to commit @idebr's patch in #6 so that we can, as @idebr stated in #2909960: Plan for Field Group 8.x-3.0, "go through the issue queue and help with issue triage and add test coverage where necessary."?
Comment #12
swentel commentedCommitted and pushed, thanks!
Comment #13
swentel commentedComment #14
idebr commentedCheers! I filed a followup to enable strict config schema checking at #3085225: Enable strict config schema checking in \Drupal\Tests\field_group\Functional\ManageDisplayTest