Drupal 9 Deprecated Code Report [#3073409]

5/5 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

------ -----------------------------------------------------------------------------------
Line src/Controller/VatNumberController.php
------ -----------------------------------------------------------------------------------
78 Call to deprecated method strtoupper() of class Drupal\Component\Utility\Unicode:
in Drupal 8.6.0, will be removed before Drupal 9.0.0. Use
mb_strtoupper() instead.
78 Call to deprecated method substr() of class Drupal\Component\Utility\Unicode:
in Drupal 8.6.0, will be removed before Drupal 9.0.0. Use
mb_substr() instead.
79 Call to deprecated method strtoupper() of class Drupal\Component\Utility\Unicode:
in Drupal 8.6.0, will be removed before Drupal 9.0.0. Use
mb_strtoupper() instead.
79 Call to deprecated method substr() of class Drupal\Component\Utility\Unicode:
in Drupal 8.6.0, will be removed before Drupal 9.0.0. Use
mb_substr() instead.
------ -----------------------------------------------------------------------------------

Comment	File	Size	Author
#6	vat_number-3073409-6-for-lenient-composer.patch	1.27 KB	daften
#6
#6	vat_number-3073409-6.patch	1.17 KB	daften
#6	8.x-1.x: PHP 7 & MySQL 5.5, D8.9.16 1 pass
#2	vat_number-3073409-1.patch	912 bytes	joy29
#2	8.x-1.x: PHP 7.2.x-dev & MySQL 5.5, D8.7 1 pass

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

8 August 2019 at 04:59

joy29 created an issue. See original summary.

Comment #2

joy29 CreditAttribution: joy29 commented 8 August 2019 at 05:00

File	Size
vat_number-3073409-1.patch	912 bytes
8.x-1.x: PHP 7.2.x-dev & MySQL 5.5, D8.7 1 pass

patch for drupal 9 compatibility

Comment #3

joy29 CreditAttribution: joy29 commented 8 August 2019 at 05:01

Assigned:	joy29	» Unassigned
Status:	Active	» Needs review

Comment #4

daften CreditAttribution: daften at Dropsolid commented 25 March 2021 at 01:32

Status:

Needs review

» Reviewed & tested by the community

Looks good

Comment #5

maartendeblock CreditAttribution: maartendeblock commented 14 April 2021 at 08:01

I can also confirm the patch works.

Comment #6

daften CreditAttribution: daften at Dropsolid commented 11 October 2021 at 21:23

File	Size
vat_number-3073409-6.patch	1.17 KB
8.x-1.x: PHP 7 & MySQL 5.5, D8.9.16 1 pass
vat_number-3073409-6-for-lenient-composer.patch	1.27 KB

I've created two patches, one that encompasses #3129833 and can be applied to the branch. A second one that will apply with composer-patches and using the new lenient composer repository (see https://www.drupal.org/docs/develop/using-composer/using-drupals-lenient-composer-endpoint). This way it can be easier to include the module in a D9 upgrade.

I'm leaving the issue in RTBC, since nothing really changed.