This meeting:
➤ Is for core migrate maintainers and developers and anybody else in the community with an interest in migrations
➤ Usually happens every Thursday and alternates between 1400 and 2100 UTC.
➤ Is done over chat.
➤ Happens in threads, which you can follow to be notified of new replies even if you don’t comment in the thread. You may also join the meeting later and participate asynchronously!
➤ Has a public agenda anyone can add to here.
➤*Transcript will be exported and posted* to the agenda issue. For anonymous comments, start with a :bust_in_silhouette: emoji. To take a comment or thread off the record, start with a :no_entry_sign: emoji.
0️⃣ Who is here? Please state your name and favorite PHP-FIG standard (accepted, rejected, draft, or deprecated)
mikelutz | Mike, migration sub-system maintainer, and big fan of PSR-4 |
damienmckenna | Damien, I prefer figs that are dried :slightly_smiling_face: |
Gábor Hojtsy (he/him) | hi! |
dinarcon | Hi, Mauricio here :wave: |
alison | Alison here, and I don't know what that means, but I dislike all figs :) they even bother me when I've had new-fangled foods that use figs as sweetener (I think it might be a paleo thing?)...Exception! Fig Newtons. I imagine those taste nothing like real figs :) |
Joshua Turton (srjosh) | @Joshua Turton (srjosh) is here |
damienmckenna | Mmmm fig newtons! |
heddn | @heddn is here. PSR-7 |
1️⃣ What do we need to discuss beyond triaging the issue queue?
mikelutz | Lots of NR issues this week. |
dinarcon | I would like to include some version of https://understanddrupal.com/migrations to the official docs and wonder what is the best way to do it |
2️⃣ Multilingual NR issues
mikelutz | #2966856: Hide and disable Drupal Migrate Multilingual |
mikelutz | I guess that’s the only one. |
Gábor Hojtsy (he/him) | why did that turn out to be so big? |
mikelutz | removing the module name from the public $modules = [..]; array of many many many test files, I think. |
Gábor Hojtsy (he/him) | yeah I mean this: “I think the next step here is to create d6 and d7 db versions with out the i18n and/or entity translation enabled and run the full migration tests on those.” |
Gábor Hojtsy (he/him) | is that not what is being already tested? |
mikelutz | Ah, that comment may be more of a follow up/separate issue, I need to talk to @quietone a bit more on it. |
mikelutz | We’ve been discussing a lot lately about how best to test the myriad of combinations of D7 and D8 modules that might be installed during a migration. We’ve tended towards testing the most complicated configurations, but how do we prove that the simpler configurations still work. |
quietone | Yes, the extra testing should be done in a separate issue. The latest patch does hide and disable migrate_drupal_multilingual and can be reviewed for that. |
Gábor Hojtsy (he/him) | Ok I could not tell if the comments were nice to have / could have / should have or requirement, that was not indicated |
3️⃣ Add more tests of node revisions
mikelutz | #3079298: Add more tests of node revisions |
mikelutz | RTBC |
4️⃣ MigrationPluginManager::createInstance() doesn’t throw an exception when failing to create an instance (edited)
mikelutz | #2744323: MigrationPluginManager::createInstance() doesn't throw an exception when failing to create an instance |
mikelutz | Commented |
5️⃣ Sql id_map should respect ID schema from config
mikelutz | #3078586: Sql id_map should respect ID schema from config |
mikelutz | Closed, Works as designed |
6️⃣ Use generators by default in source plugins
mikelutz | #3017237: Use generators by default in source plugins |
heddn | @mikelutz I can’t RTBC this, but I think its ready again. |
mikelutz | Oooh, I never did touch that one. |
mikelutz | I’ll take a look. |
7️⃣ Migrate UI - use module name not machine name on Review Page
mikelutz | #3024682: Migrate UI - add human-friendly module names to the Review form |
8️⃣ Improve the documentation on executeMigrations
mikelutz | #2978288: Improve the documentation on executeMigrations |
alison | I'll review this one. |
9️⃣ static_map process plugin incorrctly detects NULL values
mikelutz | #3077322: Add test for NULL source value to test of static_map process plugin |
alison | Oo that's a good one.... |
alison | @xurizaemon do you want to stay assigned to review? |
mikelutz | I commented on this one. |
xurizaemon | didn't get to it last weekend like i hoped - @alison if you want to take the assignment i won't object, i might get to it this weekend (tonight!!) |
alison | looks like Mike had a comment on it anyway -- I'll hang back for now :smile: (but i did review the other one you were assigned on) |
xurizaemon | thanks! |
1️⃣ 0️⃣ Undeprecate Drupal\comment\Plugin\migrate\source\d6\Comment::prepareComment()
mikelutz | #3069055: Undeprecate Drupal\comment\Plugin\migrate\source\d6\Comment::prepareComment() |
mikelutz | @heddn Can you take a look at this one, it’s one of the last few deprecation issues we need to resolve. |
1️⃣ :one: Invalid argument supplied for foreach() Migration.php:352
mikelutz | #2886349: Invalid argument supplied for foreach() Migration.php:352 |
1️⃣ 2️⃣ Change length in make_unique_entity_field to less than 32
mikelutz | #3046397: Change length in make_unique_entity_field to less than 32 |
1️⃣ 3️⃣ D7 to D8 Book Migration “SQLSTATE[23000]: Integrity constraint violation: 1062 Duplicate entry”
mikelutz | #3010123: D7 to D8 Book Migration "SQLSTATE[23000]: Integrity constraint violation: 1062 Duplicate entry" |
1️⃣ 4️⃣ 31 days of migrations has been an outstanding success, thanks to @dinarcon and his brother! How best can we include these guides in the official documentation and make sure that they are disseminated to those who could use them?
mikelutz | @Gábor Hojtsy (he/him) do you have any thoughts as a product manager? |
Joshua Turton (srjosh) | pull them into drupal.org as actual documentation pages |
dinarcon | Thanks everyone for helping us understanding the Migrate API. For integrating with the official docs, I wonder 1) if it can be copied over in full like this book https://www.drupal.org/documentation/the-essentials-7 2) if it should be broken down into "recipes" (self-contained examples)? 3) if it should be broken apart and add the relevant pieces into the existing documentation topics/pages? (edited) |
alison | EDIT: my bad, I was thinking of a "book" like a Drupal book structure, not an e-book. (But I guess they're not mutually exclusive (quite the opposite, based on the linked-to example), so I'll keep the rest of my comment here.)I like the book idea! I like when I get to find and read a whole ton of documentation about a tool in one place -- or maybe that's actually more like option 3....?Or, maybe it depends on how much is already on d.o? If the answer is "not a ton," maybe the book method could work, and other doc pages could be woven into the book structure..... (edited) |
Joshua Turton (srjosh) | IMO "not a ton" is accurate. particularly compared to your work. I've written a few blog posts but definitely could not keep up with your pace :wink: |
Participants:
mikelutz, damienmckenna, Gábor Hojtsy (he/him), dinarcon, alison, Joshua Turton (srjosh), heddn, quietone, xurizaemon
Comments
Comment #4
quietone CreditAttribution: quietone as a volunteer commentedComment #9
quietone CreditAttribution: quietone as a volunteer commentedComment #10
quietone CreditAttribution: quietone as a volunteer commentedComment #12
quietone CreditAttribution: quietone as a volunteer commentedComment #13
quietone CreditAttribution: quietone as a volunteer commentedComment #14
quietone CreditAttribution: quietone as a volunteer commentedComment #15
quietone CreditAttribution: quietone as a volunteer commentedComment #16
quietone CreditAttribution: quietone as a volunteer commentedComment #17
quietone CreditAttribution: quietone as a volunteer commentedComment #19
quietone CreditAttribution: quietone as a volunteer commentedComment #21
quietone CreditAttribution: quietone as a volunteer commentedComment #22
quietone CreditAttribution: quietone as a volunteer commentedComment #25
quietone CreditAttribution: quietone as a volunteer commentedOn Slack, alison told me that her d.o name is alisonjo315 not alison. So, I am correcting the credit.