The current index tests only have one index type (_test_) and therefore don't have any guarantee that results are not crossing over. This addition sets the stage for more rigorous testing and does some basic smoke tests to see that changing the index type in the query indeed produces the right results.

CommentFileSizeAuthor
#7 search.patch2.44 KBrobertdouglass
#5 search.test.patch2.61 KBrobertdouglass
#3 search.test.patch2.61 KBrobertdouglass
#2 search.test.patch2.16 KBboombatower
searchtest.patch2.29 KBrobertdouglass

Comments

robertdouglass’s picture

robertdouglass commented
Title: Testing: add second index type and guarantee no cross-over results » Testing: Search: Add second index type and guarantee no cross-over results
boombatower’s picture

boombatower commented
StatusFileSize
new search.test.patch2.16 KB

Looks good, I would recommend making _test_: in the documentation a bit more clear, but that is very small.

Re-rolled against HEAD and removed a bit of white-spacing.

I'm not up on searching stuff, and minor issue so leaving as needs review.

robertdouglass’s picture

robertdouglass commented
StatusFileSize
new search.test.patch2.61 KB

Added comments for _test_, found a stray instance of foo. Foo tends to sneak in if you're not watching.

lilou’s picture

lilou commented

Small typo : +// In this test we test witl _test_ and _test2_ as the type.

robertdouglass’s picture

robertdouglass commented
StatusFileSize
new search.test.patch2.61 KB
Anonymous’s picture

Anonymous (not verified) commented
Status: Needs review » Needs work

The last submitted patch failed testing.

robertdouglass’s picture

robertdouglass commented
Status: Needs work » Needs review
StatusFileSize
new search.patch2.44 KB

Rerolled. Tests pass.

Status: Needs review » Needs work

The last submitted patch failed testing.

boombatower’s picture

boombatower commented
Status: Needs work » Needs review

due to failure in HEAD: #74645: modify file_scan_directory to include a regex for the nomask.

catch’s picture

catch
he/him
Primary language English
commented
Title: Testing: Search: Add second index type and guarantee no cross-over results » Tests for multiple search index types
Component: tests » search.module
Category: bug » task
Status: Needs review » Reviewed & tested by the community
Issue tags: +Needs tests

Looks good to me. Still applies and passes.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Committed to HEAD. Thanks!

Status: Fixed » Closed (fixed)
Issue tags: -Needs tests

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +Needs tests

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.