Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Problem/Motivation
API page: https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Core%21Annotatio...
Enter a descriptive title (above) relating to Annotation for translatable text, then describe the problem you have found:
@ Translation("Bundle !title", arguments = {"!title" = "Foo"}),
Proposed resolution
should read
@ Translation("Bundle @title", arguments = {"@title" = "Foo"}),
Remaining tasks
User interface changes
API changes
Data model changes
Release notes snippet
| Comment | File | Size | Author |
|---|---|---|---|
| #10 | fix-title-placeholder-3084345-10.patch | 615 bytes | solide-echt |
| #10 | fix-title-placeholder-3084345-10-8-interdiff.txt | 4.03 KB | solide-echt |
| #8 | fix-title-placeholder-3084345-8.patch | 4.63 KB | gdejonghe |
Comments
Comment #2
valthebaldComment #3
gdejonghe CreditAttribution: gdejonghe as a volunteer and at Business & Decision commentedHello, I'm at Drupalcon Amsterdam and I'm going to work on this issue with @solide-echt and @mbovan .
Comment #4
solide-echt CreditAttribution: solide-echt as a volunteer commentedCurrently at Drupalcon2019 AMS and going to work on this issue with @mbovan and @gdejonghe.
Comment #5
gdejonghe CreditAttribution: gdejonghe as a volunteer and at Business & Decision commentedUpdated the issue summary
Comment #6
wengerkHey there ! I'm mentoring - alongside with @ mbovan - @gdejonghe and @solide-echt at the Drupalcon in Amsterdam 2019.
Let's create a patch for this issue and having fun !
Comment #7
mbovan CreditAttribution: mbovan as a volunteer and at MD Systems GmbH commentedHey! We have our local setups ready and looking into fixing the issue now with @solide-echt and @gdejonghe.
Comment #8
gdejonghe CreditAttribution: gdejonghe as a volunteer and at Business & Decision commentedI fixed the translation placeholder.
Comment #9
valthebald@gdejonghe: looks like you've submitted default.settings.php that doesn't belong to this issue. Can you reroll with only Translation.php please?
Comment #10
solide-echt CreditAttribution: solide-echt as a volunteer commentedI addressed the comment from #9 in the interdiff
Comment #12
Sutharsan CreditAttribution: Sutharsan at LimoenGroen commentedI've checked the patch, it looks good not. It complies to the example in the issue summary.
The line is part of a code example and is not actually used. Therefore it does not need a test.
When the test bot agrees and goes green, this patch is ready to go and can be set RTBC.
Comment #13
Sutharsan CreditAttribution: Sutharsan at LimoenGroen commentedJust to be sure, I further checked if any other cases of
!appeared within@Translation(). I used this simple and not too strict regexTranslation\(["|'].* !. I did not find any other case.Comment #14
mbovan CreditAttribution: mbovan as a volunteer and at MD Systems GmbH commentedLooks great! We checked the remaining uses of
!placeholder with @gdejonghe and did not anything remaining.Comment #15
alexpottCrediting all the people who worked together on this patch. Plus @aklump for filing the issue.
Comment #16
alexpottCommitted and pushed 6ca44f7895 to 9.0.x and eb2b7a4065 to 8.9.x and 87e53830b6 to 8.8.x. Thanks!
Backporting to 8.8.x because this is a docs fix.