Found out while debugging #3086008: Removing a DS layout sets groups region to hidden instead of 'content'

Field Group sets the region of a group to $default_region, being hidden if it doesn't know about the layout in field_group_field_overview_submit(). It knows a bit about field layout module, but that one is going away anyway, so we should set the available_regions to those of the ds layout if enabled.

This isn't critical because DS comes in first to render the form and or display, however, the information in the entity display config is wrong.

CommentFileSizeAuthor
#6 3086017-5.patch2.35 KBswentel

Comments

swentel created an issue. See original summary.

swentel’s picture

swentel commented
Issue summary: View changes
swentel’s picture

swentel commented
Title: Field group sets region to hidden if DS is activated » Field group sets region to hidden if DS is activated and there is no 'content' region

This happens in any DS layout, but it's easy to see in say a two column layout where the region keys are 'left' and 'right'.

swentel’s picture

swentel commented
Issue summary: View changes
swentel’s picture

swentel commented
Status: Active » Needs review

This adds the ds info so that the region info is ok for the field group.

There's an issue in DS to reset the field group form_state params in case the layout is deactivated, see #3086024: Reset field group state params when layout is deactivated.

swentel’s picture

swentel commented
StatusFileSize
new 3086017-5.patch2.35 KB

And now with patch

  • swentel committed 8120aed on 8.x-3.x 
    Issue #3086017 by swentel: Field group sets region to hidden if DS is...
swentel’s picture

swentel commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.