Tests were failing for #3073177: Add tests for field_group 3.x because they didn't set the region.

When creating a new field group, there's no default region set, not even a key in in the configuration.
Let's at least set one, defaulting to content, and double check also if DS is enabled.

CommentFileSizeAuthor
#6 3086050-6.patch6.2 KBswentel
#4 3086050-4.patch5.93 KBswentel

Comments

swentel created an issue. See original summary.

swentel’s picture

swentel commented
Issue summary: View changes
swentel’s picture

swentel commented
Priority: Normal » Critical

Raising to critical. Check the entity display and there's no region key indeed. While you will probably start configuring after, it's a good idea to at least set one.

swentel’s picture

swentel commented
Status: Active » Needs review
StatusFileSize
new 3086050-4.patch5.93 KB

Failing test.

Took the liberty to fix the docs at the same time too.

Status: Needs review » Needs work

The last submitted patch, 4: 3086050-4.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

swentel’s picture

swentel commented
Status: Needs work » Needs review
StatusFileSize
new 3086050-6.patch6.2 KB

Went for the easy fix: set the region to 'hidden'. You're going to reconfigure the display anyway afterwards. This makes sure though the configuration is valid.

  • swentel committed ba42e00 on 8.x-3.x 
    Issue #3086050 by swentel: Set default region when creating a field...
swentel’s picture

swentel commented
swentel’s picture

swentel commented
Status: Needs review » Fixed

I mean fixed :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.