Currently, if running multiple migrations, when one migration reports any failure, the entire process stops with that migration and subsequent migrations are not run. That's not necessarily desirable, especially when developing a set of migrations where you'd like it to run the whole thing and gather all the errors from all the migrations rather than have to identify and fix them one at a time. So, I propose a --continue-on-failure option to the migrate-import command, which will run all selected migrations whether or not one in the middle fails.

I've done this in the context of my current project, I need to generate a patch against dev.

CommentFileSizeAuthor
#11 3092369-migrate_tools-drush8.patch3.92 KBagentrickard
#5 3092369-5.patch10.42 KBheddn
#5 interdiff_4-5.txt2.91 KBheddn
#4 interdiff_2-4.txt6.41 KBheddn
#4 3092369-4.patch8.55 KBheddn
#2 migrate_tools-continue-on-failure-3092369-2.patch6.06 KBmikeryan
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mikeryan created an issue. See original summary.

mikeryan’s picture

mikeryan
he/him
Primary language English
Location Murphysboro, IL, USA
CreditAttribution: mikeryan at Tag1 Consulting for American Federation of Teachers commented
Assigned: mikeryan » Unassigned
Status: Active » Needs review
FileSize
migrate_tools-continue-on-failure-3092369-2.patch6.06 KB

I had trouble getting DrushCommandsTest to run locally, let's see how the testbot does...

heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn at MTech, LLC commented

It seems to be missing a few places. And this will too. But it seems closer.

heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn at MTech, LLC commented
FileSize
3092369-4.patch8.55 KB
interdiff_2-4.txt6.41 KB

Missed uploading the patch and interdiff last night. But here's everything; and it passes on local. Let's see what the testbot thinks.

heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn at MTech, LLC commented
FileSize
interdiff_4-5.txt2.91 KB
3092369-5.patch10.42 KB

Seems we need to add the continue-on-failure option to migrate:status as well. Which makes sense. This does that and adds some more test coverage.

mikeryan’s picture

mikeryan
he/him
Primary language English
Location Murphysboro, IL, USA
CreditAttribution: mikeryan at Tag1 Consulting for American Federation of Teachers commented

Ah, nice improvements - thanks @heddn!

heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn at MTech, LLC commented
Status: Needs review » Reviewed & tested by the community

I'll take that as RTBC.

heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn at MTech, LLC commented
Status: Reviewed & tested by the community » Fixed

  • heddn committed 94bf91a on 8.x-4.x 
    Issue #3092369 by heddn, mikeryan: Add continue-on-failure option
heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn at MTech, LLC commented
Status: Reviewed & tested by the community » Fixed
agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
CreditAttribution: agentrickard at Palantir.net commented
FileSize
3092369-migrate_tools-drush8.patch3.92 KB

And a patch for Drush 8, which needs review, but I'm not going to change status for it.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Lendude’s picture

Lendude
Primary language Dutch
Location Amsterdam
CreditAttribution: Lendude at iO commented

Late to the party, but thanks SOOOO much for this! Made my day :)