In the related issue #2890859: PHP71 Compatibility issue with safe_mode it was already explained this code isn't harmful.

However doing a Code Sniff for PHP Compatibility still triggers:

FILE: feeds\libraries\http_request.inc
-------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------
 432 | WARNING | INI directive 'safe_mode' is deprecated since PHP 5.3 and removed since PHP 5.4
-------------------------------------------------------------------------------------------------

Whacking in a directive to make phpcs ignore that line would make my OCD happy...;)

CommentFileSizeAuthor
#6 feeds-PHPCompatibility-3104226_fixed.png61.69 KBRajatC
#5 feeds_phpcompatiblity_issue_fixed.png25.82 KBravikk-drupal
#2 phpcs_ignore_safe_mode-3104226-2.patch523 bytesSpokje
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Spokje created an issue. See original summary.

Spokje’s picture

Spokje
Primary language Dutch
CreditAttribution: Spokje at Annertech commented
FileSize
phpcs_ignore_safe_mode-3104226-2.patch523 bytes
knyshuk.vova’s picture

knyshuk.vova CreditAttribution: knyshuk.vova at Internetdevels commented
Status: Active » Needs review
ravikk-drupal’s picture

ravikk-drupal CreditAttribution: ravikk-drupal at TATA Consultancy Services for Pfizer, Inc. commented
Assigned: Unassigned » ravikk-drupal
ravikk-drupal’s picture

ravikk-drupal CreditAttribution: ravikk-drupal at TATA Consultancy Services for Pfizer, Inc. commented
Assigned: ravikk-drupal » Unassigned
Status: Needs review » Reviewed & tested by the community
FileSize
feeds_phpcompatiblity_issue_fixed.png25.82 KB

This patch #2 works for me. Screenshot attached for the same.

RajatC’s picture

RajatC CreditAttribution: RajatC at TATA Consultancy Services for Pfizer, Inc. commented
Assigned: Unassigned » RajatC
FileSize
feeds-PHPCompatibility-3104226_fixed.png61.69 KB

This patch #2 works for me. Screenshot attached for the same.
https://www.drupal.org/files/issues/2020-05-15/feeds-PHPCompatibility-31...

RajatC’s picture

RajatC CreditAttribution: RajatC at TATA Consultancy Services for Pfizer, Inc. commented
Assigned: RajatC » Unassigned
joelpittet’s picture

joelpittet
Primary language English
Location Vancouver
CreditAttribution: joelpittet as a volunteer and at The University of British Columbia commented
Status: Reviewed & tested by the community » Fixed

Thanks @Spokje, I've committed this to the dev branch.

  • joelpittet committed d50dc97 on 7.x-2.x authored by Spokje 
    Issue #3104226 by Spokje, ravikk-drupal, Rajat Charde, knyshuk.vova:...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

solideogloria’s picture

solideogloria CreditAttribution: solideogloria commented
Issue summary: View changes