FYI, tests are broken in 8.x-3.x. I attempted to get them up to date in the 8.x-3.x-tests branch, available on d.o, github, and gitlab, but struck out. I would appreciate some help.

CommentFileSizeAuthor
#14 taxonomy_menu--tests_are_broken_in_8x3x--3107149_14.patch7.05 KBrwanth
#10 taxonomy_menu--tests_are_broken_in_8x3x--3107149_10.patch6.3 KBrwanth
#5 3107149-5.patch1.22 KBNeslee Canil Pinto
#3 3107149-3.patch1.91 KBNeslee Canil Pinto
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dstol created an issue. See original summary.

dstol’s picture

dstol
Primary language English
CreditAttribution: dstol as a volunteer commented
Issue summary: View changes
Neslee Canil Pinto’s picture

Neslee Canil Pinto
he/him
Primary language English
CreditAttribution: Neslee Canil Pinto at Specbee commented
Status: Active » Needs review
FileSize
3107149-3.patch1.91 KB

Status: Needs review » Needs work

The last submitted patch, 3: 3107149-3.patch, failed testing. View results

Neslee Canil Pinto’s picture

Neslee Canil Pinto
he/him
Primary language English
CreditAttribution: Neslee Canil Pinto at Specbee commented
Status: Needs work » Needs review
FileSize
3107149-5.patch1.22 KB

Status: Needs review » Needs work

The last submitted patch, 5: 3107149-5.patch, failed testing. View results

dstol’s picture

dstol
Primary language English
CreditAttribution: dstol as a volunteer commented
Issue tags: +Drupal 9 compatibility, +Drupal 9 porting weekend
rwanth’s picture

rwanth
he/they
Primary language English
Location New York, USA
CreditAttribution: rwanth commented

I was able to take a look at this today.

The final test, testTranslatedMenuLink, is failing because entity_type.manager's attempt to getStorage for a taxonomy_term fails in TaxonomyMenuMenuLink's getTitle() and getDescription() functions.

@dstol, before I continue can you confirm that you're experiencing the same issues I am?

dstol’s picture

dstol
Primary language English
CreditAttribution: dstol as a volunteer commented

I think so, it's been a while though. I'm mainly concerned with what the testbot says. If you've got a patch, post it here.

rwanth’s picture

rwanth
he/they
Primary language English
Location New York, USA
CreditAttribution: rwanth commented
FileSize
taxonomy_menu--tests_are_broken_in_8x3x--3107149_10.patch6.3 KB

Okay, so I rolled back from the test branch to dev-master and focused on the existing tests. I've refactored the files to meet PSR-4 standards and updated to use WebAssert. This should pass.

rwanth’s picture

rwanth
he/they
Primary language English
Location New York, USA
CreditAttribution: rwanth commented
Status: Needs work » Needs review

IMO I think we should resolve this issue and then create another one that outlines requirements for new tests. I made some progress on that front as well, but I left it out of this patch.

  • dstol committed a8c8c00 on 8.x-3.x authored by rwanth 
    Issue #3107149 by Neslee Canil Pinto, rwanth, dstol: Tests are broken in...
dstol’s picture

dstol
Primary language English
CreditAttribution: dstol as a volunteer commented
Status: Needs review » Fixed

Awesome rwanth! Thanks for your very critical contribution!

As for the follow up testing issue, the only real guidance I can give is that tests need to ensure confidence in community patch submissions. I don't think they are there today.

Please do file a follow up for that outstanding test work too.

rwanth’s picture

rwanth
he/they
Primary language English
Location New York, USA
CreditAttribution: rwanth commented
Status: Fixed » Needs work
FileSize
taxonomy_menu--tests_are_broken_in_8x3x--3107149_14.patch7.05 KB

Looks like the refactor didn't apply in the commit and just removed the files, let's try that again. :)

Attached should recreate the files in the appropriate directories.

  • dstol committed b807223 on 8.x-3.x authored by rwanth 
    Issue #3107149 by rwanth, Neslee Canil Pinto, dstol: Tests are broken in...
dstol’s picture

dstol
Primary language English
CreditAttribution: dstol as a volunteer commented
Status: Needs work » Fixed

Whoops, thanks for catching that.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Parent issue: » #3158358: Plan for Taxonomy Menu 8.x-3.5