Change the logo as it doesn't follow the Sign in Branding Guidelines

Nice Mokshit,

I love to have the option to switch between Light or Dark
Like what I did in #3108790: Update [Vardoc Theme] to use the latest Vartheme BS3 with (Bootstrap 3 LESS) changes and Bootstrap 3.4.1

Login in with new Google login button brand style ( Dark )

Not sure if it would be good to have an option setting, It could be in the Social Auth to use Button style + Light or Dark

Still researching.

I'm not sure how the patch is to be applied, and worried about the description of #2 -

8.x-2.x: PHP 7.2 & MySQL 5.5, D8.9 Patch Failed to Apply

Would it work if I just replaced the google_logo.svg file at /modules/social_auth_google/img/ and changed permissions to a+rw ?

EDIT: Comment #2 earlier displayed some security warning, it has since gone.

The original patch failed to apply

Thanks for the re-roll, @Vishalghyv.

Currently the base configuration of the Social Auth modules lines all available auth methods up with a restricted width. This change (patch in #12) results in a squished image like this:

I think we'll need a new issue in the Social Auth issue queue to address how these login buttons on displayed. They probably should not be so constrained. I'm going to move this issue to postponed for now. Happy if anyone here is willing to get the new issue going over at the Social Auth module. Otherwise I will do so at some point.

Reopening this from Postponed to Active. New users of this module cannot get their Google App through the Google verification process. I just received an email with the following content:

--clips--
[Action Needed]

Hi,

Thanks for your patience while we reviewed your project.

The Google sign-in button on your app’s homepage URL is not compliant with the Google sign-in branding guidelines.

Please update the Google sign-in button on your website according to the Google sign-in branding guidelines. After updating the Google sign in button, please respond directly to this email in order to proceed with the verification process.
--clips--

@wells, you mentioned in #13 that the topic should be addressed in Social Auth issue queue so that other login providers' links would look consistent. I just checked the Social Auth issue queue but couldn't find any open issues for this topic?

Cheers,
Markus

@wells, you mentioned in #13 that the topic should be addressed in Social Auth issue queue so that other login providers' links would look consistent. I just checked the Social Auth issue queue but couldn't find any open issues for this topic?

You're right -- I shouldn't have postponed this issue without a new one in the SA queue. I invite anyone affected by this issue to add one there (and provide an MR to address it, preferably!). This isn't something I've had to address in regular use of the module because in all my use cases we override the templates anyway with custom designs.

Not that I don't think this is an important issue (it certainly is if it's causing verification rejections) just not something I am able to prioritize with the time I have at the moment.

Same problem here. We had to submit the app for review.

The logo from the MR!4 can be reviewed here: https://git.drupalcode.org/project/social_auth_google/-/blob/589549224dc...

Looking at https://developers.google.com/identity/branding-guidelines?hl=de > Symbol that seems correct to me.

I guess settings might be added in a follow-up, first we should get this valid again?

LGTM as reported in #20

@wells do you agree? Then I think we should try to fix and publish this asap?
Can someone create a follow-up feature request for the settings please?

Ok yeah this makes sense. Hopefully this is good enough to get folks through review. Will cut a new release now.

Thank you @wells! :)