March 9, 2020 - Meeting Agenda [#3117154]

Meeting Agenda

Introductions
Path to beta: https://www.drupal.org/project/drupal/issues/3111409
Issue updates and discussion

Meeting Details

Time: 2pm UTC (10am Eastern)
‬Meeting Location: #d9-theme channel on drupal.slack.com

Meeting Minutes

Hello, welcome to this week’s Front-end theme Olivero meeting!• This meeting happens every Monday at 2pm GMT (10am ET)• There is no audio or video -- this meeting is chat only• The conversations for this meeting happen in threads0️⃣ If you’re attending this meeting, please let us know here and leave a comment in the meeting agenda issue so we can give you issue credit on d.o.: #3117154: March 9, 2020 - Meeting Agenda

mtift (he/him)	Let's get this party started
Brian Hogue	I’m attending :hand:
mherchel	Hi! :wave:
jackh	present and attending here :wave:
shaal	Hi!
Putra Bonaccorsi	Hello and good morning/afternoon!
brianperry	Greetings!
kbeck303	hello everyone :wave:
ellenoise (she/her)	Hello!
thejimbirch	Good Morning!
vulcanr	just saw the notice
vulcanr	:disappointed:

1️⃣ Excitement is building as we are starting to develop a path to beta: #3111409: Add new Olivero frontend theme to Drupal 9.1 core as beta

mtift (he/him)	Much has happened in the previous week
Putra Bonaccorsi	Indeed! As @mtift (he/him) noted above, we've gathered a list of features/must-haves for the beta release of the Olivero theme. These issues are based on the designs that we have for the new Drupal 9 theme, however, please take and look and feel free to submit issues for features that you think are missing from our current plan. We'd love to get as many feedback as possible on whether the current meets the beta requirement.Link: #3111409: Add new Olivero frontend theme to Drupal 9.1 core as beta#beta-criterias (edited)
mherchel	For an idea on when the D9 beta will be released, see https://groups.drupal.org/node/535810The tl;dr is that we’ll know more by this Friday
mtift (he/him)	A lot of folks have been asking about how they can help, so at the moment this issue is the place. The better we can anticipate the requirements, the easier the path forward. It lays out our TODO list and should help make it more clear how to contribute going forward.
mtift (he/him)	As you can see, core maintainers are looking at this issue and making sure we're on the right track, so making sure that issue is complete should make their job easier
Putra Bonaccorsi	Just a to piggyback off @mtift (he/him). We also started to group some of these issues into a sprint board, so that we have a clear view on what needed to be done in the next couple of weeks. Here's the direct link to our current sprint board. https://contribkanban.com/sprint/olivero-sprint-d
Putra Bonaccorsi	Feel free to take on issues that you see fit.

2️⃣ Issue updates and status

Participants:

mtift (he/him), Brian Hogue, mherchel, jackh, shaal, Putra Bonaccorsi, brianperry, kbeck303, ellenoise (she/her), thejimbirch, vulcanr

mtift (he/him)	Here is where we discuss other issues that need some extra attention
mherchel	I don’t have an issue on D.O for this, but I’m continuing work on the proof of concept.Specifically, I’m working on the ability for people to turn on an “always on” mobile navigation, in the event that they have a lot of top level navigation items.
mherchel	This will be triggered by a theme setting, that will activate a is-always-mobile-nav CSS class on the body element.
mherchel	Currently, I’m working on some accessibility issues within it, including focus states, and closing the menu via ESC (and having the subnav items close first)
mherchel	My plan is to have this wrapped up within a day or two.
thejimbirch	I had a question on the canonical source of the design. While working on the breadcrumb ticket, I noticed the Figma designs were different than the Proof of Concept.I went with the Figma, but would love clarity on this.
mherchel	Then I want to cease work on the PoC, move all styles, JS, Markup into the theme, and do work there
mherchel	@thejimbirch Go with Figma. There are some differences where we accommodate Drupal’s limitations
mherchel	for example, we can’t have the “sign up” menu item that we have in the comps
mherchel	But overall, Figma is correct
thejimbirch	Thanks @mherchel!
Putra Bonaccorsi	@thejimbirch I agree with @mherchel, the POC doesn't include all of the features that we have in Figma/design.
thejimbirch	Thanks @Putra Bonaccorsi
mherchel	I also want to shout out to @hawkeye.twolf who has been working on #3115420: Add search block(s) to the header. @Putra Bonaccorsi and / or me will likely look at this in a few days and get it committed
brianperry	I have work in progress on a couple of issues related to the always on mobile nav. Was a bit behind last week, but given your update @mherchel I'll try to devote some more time to them on the next day or two to see if I can sneak anything in before we move away from the POC.
mherchel	@brianperry thanks! I’m excited about the work on automatically transitioning between the two states.
jackh	Is there a preferred way to tee this stuff up in Drupal for review, to have everything on one page?For example, was interested in taking on form elements. Should we use Styleguide module to show all form elements at once? I’ve seen cd_tools mentioned too as a solution for this kind of thing.
mtift (he/him)	@jackh I'm not totally sure I understand the question, but in case it's not obvious we can see the Drupal issues that need review on one page here: https://www.drupal.org/project/issues/olivero?text=&status=8&priorities=... (edited)
mherchel	@jackh I think i understand the question. TBH, the answer is nope, there’s not a preferred way
mherchel	the Styleguide module would be awesome (if it does what I’m thinking it does)
brianperry	It has been a little while, but I want to say Claro had an approach to this during development.
mherchel	Keep in mind that a lot of new styles and changes are going to be coming in from the proof of concept shortly, So, make sure you keep your stuff componentized.
mherchel	@brianperry I’d love if we could integrate some of that into our tugboat environment or something
Putra Bonaccorsi	I just wanted to note that Drupal 9 Core themes are no longer using Classy or Stable as dependencies (see issue - #3108181: Decouple Classy libraries from Bartik) as we're developing the theme. I'll create an issue so that we can track this work.
mherchel	I believe we can set base_theme: false in the info file or something
jackh	@mtift (he/him) To ease the review/theming process, it’d be great to have one place that shows everything that could show up within Drupal - “the kitchen sink”. In this case, all the form elements. I’ve used Styleguide before for this which works well enough. I’d have to look into how cd_tools was used for this kind of thing on Claro. (edited)
Putra Bonaccorsi	@mherchel Yep! However, we still need to copy required libraries and templates from Classy to Olivero.
brianperry	I'll try to dig up info on the Claro approach. If I find it I'll post info in this channel.