Problem/Motivation

When doing the dry run we noticed messages like

Deleted 0 revisions for node with nid 1568.
Deleted 0 revisions for node with nid .

Debugging the code a bit more we found that in many cases there is no value for the $nid
and it is still being passed to the delete batch process

hence we propose a check to see if the nid is set.

CommentFileSizeAuthor
#2 3119141.patch987 bytesyasheshb
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

yasheshb created an issue. See original summary.

yasheshb’s picture

yasheshb CreditAttribution: yasheshb commented
FileSize
3119141.patch987 bytes

the patch below does a check if the nid is set. if not, it does not call the function to delete it.

adriancid’s picture

adriancid
Primary language Spanish
Location Montreal, Canada
CreditAttribution: adriancid at Drupiter commented
Title: unset nid being passed as parameter to _node_revision_delete_do_delete » Unset nid being passed as parameter to _node_revision_delete_do_delete
adriancid’s picture

adriancid
Primary language Spanish
Location Montreal, Canada
CreditAttribution: adriancid at Drupiter commented
Status: Active » Fixed

Thanks for the patch

  • adriancid committed 2162bbf on 7.x-3.x authored by yasheshb 
    Issue #3119141 by yasheshb, adriancid: Unset nid being passed as...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.