Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
ModulesListForm doesn't define the accessManager property it uses for route access checks.
Proposed resolution
Define the property.
Remaining tasks
Review patch.
User interface changes
n/a
API changes
n/a
Data model changes
n/a
Release notes snippet
n/a
Comment | File | Size | Author |
---|---|---|---|
#2 | 3143087-2.patch | 528 bytes | neclimdul |
Comments
Comment #2
neclimdulpatch
Comment #3
neclimdulComment #4
Kristen PolThanks for the issue and patch. Marking RTBC based on the following and because I don't think tests need to be added for this.
1) Patch applies cleanly.
2) Tests pass.
3) Patch addresses the issue noted in the issue summary.
4) Looking at the constructor, all the other parameters have properties defined.
5) The doc block matches others in core.
6) Checked all classes that initialize
$this->accessManager
to see if any other class had this issue and only sawTestUrl
not defining it in the class but it extendsUrl
which does define it so it's covered.Comment #5
alexpottWhilst this is a slight change of visibility for the property form classes are not API so this is acceptable for a minor release.
Committed 0c30b0d and pushed to 9.1.x. Thanks!