PHPBB STYLE for advanced forum module looks like (similar to ) PHPBB3 forums
As any style, copy it to your theme directory and link to it in your AF settings page
Have fun, hope you like it
Screen shots included

Files: 
CommentFileSizeAuthor
#6 phpbb_final.zip102.52 KBq8doc
3.JPG223.68 KBq8doc
2.JPG352.43 KBq8doc
phpbb_AF_style.zip68.88 KBq8doc

Comments

Status:Active» Fixed

forgot to put it as fixed

Status:Fixed» Active

Don't put it as fixed. I'm likely to miss it that way. I rarely look at fixed issues since they're, well, fixed.

I'll have a look at it soon as I can.

Michelle

Version:5.x-1.0-alpha1» 6.x-1.x-dev
Status:Active» Needs work

Ok, I gave the code a look over. A few things I noticed:

  • The styles have been undergoing massive changes recently and your code is behind.
  • There's tables for non tabular data.
  • I need to make sure the phpBB theme this is based on is GPL.

It's probably going to take me a couple of hours to get this into good enough shape to commit, so it may be a while before I can get to it. I just wanted to give you some feedback so you don't think your contribution is being ignored.

Michelle

ok no problem,
take your time
thank you for your help

Sincerly,
Besher

I just had a look at your new dev version. Is it enough if I just uploaded new icons for the links (reply | delete | mark all read |quote)
or is there any thing else that i should do?

Report module (abuse): can we add an icon for that?>

StatusFileSize
new102.52 KB

Updated style to meet the new code...
Updates:
-new icons (reply, edit, quote, delete, mark all read, contact, online, offline , new poll)
- updated advf-forum-user.tpl.php to the new code you used
- added a report icon form now in case you decided to add the link

The phpbb theme is V3.3 called prosilver, i assume its as phpbb is open source and its the default theme that comes with it
Tables:
yes i have used tables in advf-forum-post.tpl.php because it will help me adjust the online icon area, and the go to the top, trust me i have tried to use css .... never managed to get it them to fit in their places,, so i used tables.

I dont assume it makes any difference, besides, with out tables, there was a width bug in IE7 which i only managed to fix with tables.

I use tables in themes, they make your life easier, and save you alot of time, and i dont think tables are only to be used for tabular data....

i hope this will be the final dev before your next alpha... :P just kiding, your always ahead of me

Sincerely,
Bisher

I was going to suggest you wait until after the alpha before updating it. This weekend is really a bad time to be contributing a style. I'm taking every moment the kids let me at the computer to work on finalizing the styles for the alpha which means there's massive changes going on.

I'm really not keen on tables for non tabular data. They may make the designer's life easier but they're still hack. I'll take a closer look at it after the alpha and see if there's anything that can be done about it.

About the license, I admit it's probably GPL but I would really like confirmation of that. Maybe you could ask on their forums?

Thanks,

Michelle

I decided to try installing it as is and, honestly, this still needs a lot of work. I went to phpBB's demo site and compared and they aren't very close at all. It looks as though you added some of their icons to the blue_lagoon style and then just changed the style of the posts themselves. Plus, there's something weird conflict with admin_menu going on.

I'm not sure what to say at this point. I don't want to hurt your feelings and it's obvious you've really tried to make this work, but I really can't use this. Any style I add I need to support and keep up to date and I'm afraid adding this would cause me a lot of work.

I'll leave it here on the issue and people can use it if they like, but I'm not going to commit it unless I get some time to put the work in to it.

Thanks and I'm sorry,

Michelle

no problem at all,
it's been a pleasure to work with you.
the style was origionaly designed to fit into a theme am contributing... so i will just use that for the theme,,and make it available to users if they liked it

Although i heavily tested it on D5 anad D6 on all possible web browsers with no problems faced

though i will be still working on some other styles, putting into account the points you have mentioned, may be i will get to have one of my styles in ur module one day :P

I will post snapshots for users
Sincerely,
Bisher

SCREEN SHOTS FOUND AT:

http://kuwait-md.org/2.jpg
http://kuwait-md.org/3.jpg
http://kuwait-md.org/4.jpg

Status:Needs work» Closed (fixed)

closed

Status:Closed (fixed)» Fixed

Sorry, fixed to stay on the list

Glad you're not mad. If it wasn't for the fact that I need to maintain and support any style I add, I would have just tossed it in. I've been thinking of setting up a page with styles that people contribute that, for whatever reason, I'm not willing to add to the module itself. No sense denying access to them if people want to share. :)

Thanks again,

Michelle

Status:Fixed» Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.

Version:6.x-1.x-dev» 6.x-1.1

Is there a reason why it is not included in 1.1 release?

Because it's a contributed style, not part of AF.

Michelle

I've unzipped it to styles directory in AF, and it doesn't show on AF menu. What am I doing wrong?

See http://drupal.org/node/234042 "Creating a new style" for the code you need.

Michelle