[META] Symfony 6 compatibility

I'm struggling to seperate out the recently committed stuff from #16 from some of the other needed changes to get Drupal running on 5.1, so for my own education, I'm going to try a fresh patch and see if I can figure out exactly what is missing. Expect a few broken things thrown against testbot while I work through this.

bah, Sorry, @catch. I didn't realize you were working on this today. I was trying to get myself up to speed, and go the other way. Start from scratch and work in the needed typehints from your interdiffs.

I was going a different way anyway, more like what we did with SF4 and Drupal 8 where I didn't change the lock file, but ran the update in drupalci.yml. I'll let you finish, I know you've been working on it. I didn't mean to jump in, I thought you might be done for the night, and I wanted to play with it a bit.

Adding some deprecations to skip for now.

Fix for the dispatcher that was breaking a lot of kernel tests.

Going to try going back to my method of updating, which also includes a fork of mink browser kit that might work. A number of the kernel tests are failing because they are loading traits from functional tests that aren't making it into the classloader.

Remove a broken legacy mime type guesser test class referencing the legacy guesser

Response constructor won't take an array anymore. hacking HtmlResponse to try to get some Functional tests working.

Another deprecation, and a different fix for HtmlResponse.

Ooops, try this one.

Removing more legacy code from the mimetype system.

Opened #3172410: Make HtmlResponse compatible with Symfony 5 to fix #30

Opened #3172425: "Symfony\Component\Lock\Factory" is deprecated since Symfony 4.4 and will be removed in 5.0 use "Symfony\Component\Lock\LockFactory" instead (Technically a SF4 deprecation we missed somehow) to address the missing Lock Factory.

Opened #3172537: Passing a command as string when creating a "Symfony\Component\Process\Process" instance is deprecated since Symfony 4.2, pass it as an array of its arguments instead, or use the "Process::fromShellCommandline()" constructor if you need features provided as well, another SF4 deprecation that we missed.

Updated issue summary since the blocking issue was resolved. Did not yet process the children issues in my head so did not do a comprehensive list just pointed to the sidebar.

I'm still working through the remaining test failures, I have a few RTBC patches that should address a number of them in D9, so I'm going to give it a day or two to see if they get committed before I re-roll the patch, but I think I can get this green in the next week or so. I'm taking next week off from $work, so I should have more time to dedicate to this.

The current patch is testing against SF5.1 stable, so once it's green, we can push up to 5.2-dev and try to get ahead of the current SF5 dev cycle. After that we can just keep on continual maintenance hopefully. So far, I don't see any SF5 deprecations we can't handle in D9, but they still have 3 more releases in the 5.x cycle to throw curveballs at us, and I feel like they like to put a lot of them in the X.4 release. I'm super happy we are ahead of the game early this time though. Once we are caught up with 5.x-dev, we can take a more active role in the SF6 development cycle, and try and work upstream to make SF6 in D10 happen more easily.

There's good overview of coming 5.2 https://speakerdeck.com/fabpot/symfony-5-dot-2

Looks we could reconsider current set of console applications and unify it for d10 ref #2242947: Integrate Symfony Console component to natively support command line operations

Here's a re-roll with the HtmlResponse changes removed (fixed in #3172410: Make HtmlResponse compatible with Symfony 5), plus a hack fix around the metapackage fail on my temporary mink fork. A couple other issue landed, so altogether a few more failures should be fixed.

@Gábor, did you mean to reset this to active instead of NW? I know it's technically a meta issue, maybe active makes more sense.

And fixing the bad re-roll of HtmlResponse in #41...

composer lock issue fix.

@mikelutz it looks great! Thank you

23 remaining failures are straight to fix

Fixing a few more, going to open more issues. Deleting one MimeType test for now because I can't convert it as is. It uses reflection on the MimeTypeGuesser class, whose equivalant in SF5 is final. We will need to look at how to replace that test.

@mikelutz: definitely no intention to change the status.

Main blocker is #3162016: [Symfony 6] Retrieving a non-string value from "Symfony\Component\HttpFoundation\InputBag::get()" is deprecated

Updated issue summary with individual issues linked and more info about how this issue is used.

Fixed markup.

Rerolled the patch manually against 9.2.x. Some things already landed, eg. some places already use the Contracts interface from Symfony.

Somehow missed a core/composer.json change in my manual fix where the symfony/mime package was added. Adding that in.

Hm, now we get a bazillion instances of Fatal error: Trait 'Prophecy\PhpUnit\ProphecyTrait' not found in /var/www/html/core/tests/Drupal/TestTools/PhpUnitCompatibility/PhpUnit9/TestCompatibilityTrait.php on line 12. It seems like my patch updates the phpunit version to 9 from 8, so that might have something to do with this. I am not really well versed around the phpunit update magic we have. Also we may not want to update the phpunit version here, but either way it should work with an updated phpunit.

Going to pass this to others who know this better :D

Per @longwave in slack:

phpspec/prophecy-phpunit:^2 is required for phpunit 9. if you composer require that on your patch it should work

Well doing that adds quite a few more dependencies. Let's see.

I don't actually understand how I should read these fails :/ There are definitely two of these which are odd, because it says it requires that and it did find it but then it did not use it.

drupal/core-dev 9.2.99 requires behat/mink-browserkit-driver dev-SF5 as v1.3.4 -> found behat/mink-browserkit-driver[dev-SF5 dc566b2] but it does not match the constraint.

Hmm, Those composer validation issues are tricky. behat/mink-browserkit-driver dev-SF5 is my fork of browserkit that is compatible with SF5. We are cheating the system to use the fork, just to get tests running, but I'm not certain why it isn't happy, nor what to do long term about actually having a working supported mink browserkit. If I need to change anything in the fork, or if anybody wants access to commit changes to my fork, let me know. I'll try to look into it more when I have time.

https://symfony.com/blog/symfony-5-2-0-released so this should be updated to 5.2 now, the patch uses 5.1 :) Thanks @andypost for the tip.

This is #57 with Symfony 5.2 but with the PHPUnit upgrade removed as it's not needed here.

$ composer update drupal/core symfony/* behat/mink-browserkit-driver
...
$ composer-lock-diff --no-links
+------------------------------------+---------+---------+
| Production Changes                 | From    | To      |
+------------------------------------+---------+---------+
| symfony/console                    | v4.4.16 | v5.2.0  |
| symfony/debug                      | v4.4.16 | REMOVED |
| symfony/dependency-injection       | v4.4.16 | v5.2.0  |
| symfony/error-handler              | v4.4.16 | v5.2.0  |
| symfony/event-dispatcher           | v4.4.16 | v5.2.0  |
| symfony/event-dispatcher-contracts | v1.1.9  | v2.2.0  |
| symfony/http-foundation            | v4.4.16 | v5.2.0  |
| symfony/http-kernel                | v4.4.16 | v5.2.0  |
| symfony/mime                       | v5.1.8  | v5.2.0  |
| symfony/process                    | v4.4.16 | v5.2.0  |
| symfony/routing                    | v4.4.16 | v5.2.0  |
| symfony/serializer                 | v4.4.16 | v5.2.0  |
| symfony/translation                | v4.4.16 | v5.2.0  |
| symfony/validator                  | v4.4.16 | v5.2.0  |
| symfony/var-dumper                 | v5.1.8  | v5.2.0  |
| symfony/yaml                       | v4.4.16 | v5.2.0  |
| psr/event-dispatcher               | NEW     | 1.0.0   |
| symfony/deprecation-contracts      | NEW     | v2.2.0  |
| symfony/polyfill-intl-grapheme     | NEW     | v1.20.0 |
| symfony/string                     | NEW     | v5.2.0  |
+------------------------------------+---------+---------+

+------------------------------+---------+---------+
| Dev Changes                  | From    | To      |
+------------------------------+---------+---------+
| behat/mink-browserkit-driver | v1.3.4  | dc566b2 |
| symfony/browser-kit          | v4.4.16 | v5.2.0  |
| symfony/css-selector         | v4.4.16 | v5.2.0  |
| symfony/dom-crawler          | v4.4.16 | v5.2.0  |
| symfony/filesystem           | v4.4.16 | v5.2.0  |
| symfony/finder               | v4.4.16 | v5.2.0  |
| symfony/lock                 | v4.4.16 | v5.2.0  |
| symfony/phpunit-bridge       | v5.1.8  | v5.2.0  |
+------------------------------+---------+---------+

Looks like something has changed in the Symfony container between 5.1.8 and 5.2.0, as locally I run out of memory or segfault when compiling the container, and run-tests.sh crashes with

Symfony\Component\DependencyInjection\Exception\ServiceNotFoundException: The "module_handler" service or alias has been removed or inlined when the container was compiled. You should either make it public, or stop using the container directly and use dependency injection instead. in /var/www/html/drupal/vendor/symfony/dependency-injection/Container.php:266
Stack trace:
#0 /var/www/html/drupal/vendor/symfony/dependency-injection/Container.php(228): Symfony\Component\DependencyInjection\Container->make('module_handler', 1)
#1 /var/www/html/drupal/vendor/symfony/dependency-injection/ContainerBuilder.php(539): Symfony\Component\DependencyInjection\Container->get('module_handler')
#2 /var/www/html/drupal/core/lib/Drupal/Core/Test/TestRunnerKernel.php(77): Symfony\Component\DependencyInjection\ContainerBuilder->get('module_handler')
#3 /var/www/html/drupal/core/scripts/run-tests.sh(559): Drupal\Core\Test\TestRunnerKernel->boot()
#4 /var/www/html/drupal/core/scripts/run-tests.sh(51): simpletest_script_init()
#5 {main}Failed to execute command php core/scripts/run-tests.sh --list: exit status 2

Seems that services are really private by default now, and we are going to have to force public services even more than we do already: https://github.com/symfony/dependency-injection/compare/v5.1.9..v5.2.0

Explicitly setting services and aliases to public fixes at least some of the container issues, my local site and run-tests.sh both work now.

Try again without the DrupalCI container command.

And I forgot the deprecation notice.

Some more fixes, maybe enough to make the tests not blow up entirely.

We pretend that Symfony Constraint plugins are Drupal plugins, but the constructor is no longer compatible so we need to provide a new custom factory. This can probably be committed to Drupal 9/Symfony 4.

We also have to call setPublic(TRUE) all over the place for services. Not sure if this is the right way to go, or if we should be doing this at a lower level somewhere, but it does help some of the tests pass. Maybe we need to make sure we always use our Container/ContainerBuilder subclasses and handle it there if we are staying with public-by-default services.

One more setPublic() fix.

Opened #3185603: [Symfony 5] Symfony Constraint plugins are not strictly Drupal plugins to deal with the Constraint issue described in #67.

Fixed some of the container issues by forcing services to public.

+------------------------------------+---------+---------+
| Production Changes                 | From    | To      |
+------------------------------------+---------+---------+
| symfony/console                    | v4.4.16 | v5.2.0  |
| symfony/debug                      | v4.4.16 | REMOVED |
| symfony/dependency-injection       | v4.4.16 | v5.2.0  |
| symfony/error-handler              | v4.4.16 | v5.2.0  |
| symfony/event-dispatcher           | v4.4.16 | v5.2.0  |
| symfony/event-dispatcher-contracts | v1.1.9  | v2.2.0  |
| symfony/http-foundation            | v4.4.16 | v5.2.0  |
| symfony/http-kernel                | v4.4.16 | v5.2.0  |
| symfony/process                    | v4.4.16 | v5.2.0  |
| symfony/routing                    | v4.4.16 | v5.2.0  |
| symfony/serializer                 | v4.4.16 | v5.2.0  |
| symfony/translation                | v4.4.16 | v5.2.0  |
| symfony/validator                  | v4.4.16 | v5.2.0  |
| symfony/yaml                       | v4.4.16 | v5.2.0  |
| psr/event-dispatcher               | NEW     | 1.0.0   |
| symfony/polyfill-intl-grapheme     | NEW     | v1.20.0 |
| symfony/string                     | NEW     | v5.2.0  |
+------------------------------------+---------+---------+

+------------------------------+---------+---------+
| Dev Changes                  | From    | To      |
+------------------------------+---------+---------+
| behat/mink-browserkit-driver | v1.3.4  | dc566b2 |
| symfony/browser-kit          | v4.4.16 | v5.2.0  |
| symfony/css-selector         | v4.4.16 | v5.2.0  |
| symfony/dom-crawler          | v4.4.16 | v5.2.0  |
| symfony/filesystem           | v4.4.16 | v5.2.0  |
| symfony/finder               | v4.4.16 | v5.2.0  |
| symfony/lock                 | v4.4.16 | v5.2.0  |
+------------------------------+---------+---------+

psr/event-dispatcher | NEW | 1.0.0

Interesting how it compatible with pecl psr C extension https://pecl.php.net/package/psr

edit yes, it's https://github.com/jbboehr/php-psr/blob/master/psr_event_dispatcher.c#L23

A few more little fixes.

Opened #3187074: [Symfony 5] Services are private by default for the dependency injection changes.

Opened #3187857: [Symfony 6] Service deprecation messages require more fields for a new deprecation in SF 5.1.

If my local testing is right, this should be green. This is #74 with fixes for all the tests:

• Removed 'repositories' section from core-dev composer.json, not required and causes test fails
• Fixed Composer build tests by applying #3186364: Allow pre-release dependencies in Drupal pre-release milestones and an extra fix to extract the correct dev version string of behat/mink-browserkit-driver.
• Fixed the layout builder tests with another line of the patch from #3187074: [Symfony 5] Services are private by default
• Fixed the REST RequestHandlerTest with lessons learned from #3096781: symfony/mime and symfony/var-dumper versions are on 5.1.7 (not an LTS) and therefore have gaps in security coverage relative to Drupal minors

Opened #3188056: [Symfony 5] Symfony\Component\Serializer\Encoder\DecoderInterface::decode() no longer accepts NULL as $format to fix RequestHandlerTest as we can do this now.

#3188056: [Symfony 5] Symfony\Component\Serializer\Encoder\DecoderInterface::decode() no longer accepts NULL as $format landed.

#3185603: [Symfony 5] Symfony Constraint plugins are not strictly Drupal plugins landed.

I have some problems with releasing D10 with Symfony 6. Symfony 6 is to be released in november 2021. A new minor version is to be released every 6 months, in may and november. Every major and minor version will 8 months of bug- and security fixes, with the exception of the last minor release of every major release. That one will get 3 years of bug fixes and 4 years of security fixes. See: https://symfony.com/doc/current/contributing/community/releases.html.
If everything does according to plan then D10 will be release in june 2022. In the previous month will Symfony 6.1 be released. Every Drupal minor release gets 6 months of bug fixes and 12 months of security fixes. For D10.0 that will result in that in januari 2023 it will be giving 4 more months of security fixes when Symfony has stopped giving any support version 6.1. This does not sound very exceptable to me. We can update the required Symfony version for D10.0 from 6.1 to 6.2 in december 2022 or januari 2023. Only there will a risk in doing that. For instance in Symfony 5.2 they made services fully private by default. See: #3187074: [Symfony 5] Services are private by default. Which would result in a big BC break. If we want to minimize the risk of creating BC breaks we will have to go with a release of Symfony that is a LTS release. Therefore for me releasing D10 with Symfony 6 is not a acceptable option.

@catch Thank you your response and great to hear how the problem is solved. If releasing D10 with Symfony 6 is that important, can we then make all issues for getting there critical?

Session usage will need review as SF deprecated session service finally https://github.com/symfony/symfony/pull/38616

#87: that only looks like it affects FrameworkBundle which we don't use, the changes in HttpFoundation (which we do use) only add a single method.

I was wondering how we are going to add deprecation messages for stuff that gets deprecated in Symfony 5. We would like to use Symfony 6 in D10, only when we do that, we should add deprecation messages for that stuff in D9. And in D9 we use Symfony 4 and in that version in the stuff not jet deprecated. How can we fix this?
In #3162016: [Symfony 6] Retrieving a non-string value from "Symfony\Component\HttpFoundation\InputBag::get()" is deprecated we are fixing it for core, only we cannot add a deprecation message for contrib and custom modules. The when your D9 website works without getting deprecation messages your site will work in D10, is no longer valid. Is this acceptable or can we add deprecation messages in another way?

Changing the status to critical as we would like to release D10 with Symfony 6. Got the oke from @catch for this (comment #86).

Edit: Would it be possible to create a patch file that from Drupal core would update the method Symfony\Component\HttpFoundation\InputBag::get() and add deprecation message? Just an idea.

Added #3195533: [Symfony 6] The constant Symfony\Component\HttpFoundation\Request::HEADER_X_FORWARDED_ALL is deprecated. to the list with remaining tasks.

Added #3195571: [Symfony 6] The constant Symfony\Component\Routing\RouteCompiler::REGEX_DELIMITER is deprecated. to the list with remaining tasks.

#3195533: [Symfony 6] The constant Symfony\Component\HttpFoundation\Request::HEADER_X_FORWARDED_ALL is deprecated. and #3195571: [Symfony 6] The constant Symfony\Component\Routing\RouteCompiler::REGEX_DELIMITER is deprecated. have landed. Removing them from the remaining tasks list.

#3187074: [Symfony 5] Services are private by default also has landed. Also removed from the remaining tasks list.

Added #3196027: Contrib support solution needed for potential Symfony 4 to 6 upgrade, Symfony 5 only deprecations are not available in Symfony 4 to the list of remaining tasks.

Opened #3197482: Update Drupal 10 to depend on Symfony 5.4 (as a stepping stone to Symfony 6, for deprecation checking support) for the must have update to Symfony 5 and #3197483: Evaluate the potential update of Drupal 10 to Symfony 6 and do it if possible for the potential update to Symfony 6.

Now many of the compatibility fixes have been committed this is getting smaller. This is #79 rebased then upgraded to Symfony 5.2.3. The composer build tests will fail because I removed the minimum-stability changes, really we need a stable release of behat/mink-browserkit-driver.

Something went wrong when merging composer.lock, let's try again.

#3161983: [Symfony 6] Update EventDispatcherInterface type hints in constructors landed, removing from issue summary. Great progress :) Looking forward to what new things we are still to find.

Fixed two failing tests by removing MimeTypePass and another legacy test. Also testing out a deprecation fix by applying #3187857: [Symfony 6] Service deprecation messages require more fields.

#3187857: [Symfony 6] Service deprecation messages require more fields has landed.

Quick reroll of #100, it did not need #3187857: [Symfony 6] Service deprecation messages require more fields anymore, given that it landed.

Opened #3199691: [Symfony 6] Symfony no longer parses octal numbers starting with 0 alone which seems like a seldom used edge case but something we still have to deal with.

Symfony 6 requires PHP 8.0, so #3173787: [policy] Require PHP 8.1 for Drupal 10.0 if a dependency does, otherwise require PHP 8.0. (up from 7.3 in Drupal 9) must be considered, #3109885: [meta] Ensure compatibility of Drupal 9 with PHP 8.0 (as it evolves) seems to indicate compatibility, but I'm unsure if testing with 7.x handles that.

Perhaps it was assumed that 8.x would be a requirement, but I don't see it mentioned. Debian 11 will have 7.4, but 8.x is obtainable.

@GreenReaper: Drupal 10 is indeed planned to require PHP 8. See #3118147: [meta] Set Drupal 10 platform and browser requirements six months before the release. Upgrade Status is already checking for this requirement on Drupal 9 (#3202955: Start checking PHP 8 requirement on Drupal 9). PHP 7 end of life (November 2022) is only slightly later than Drupal 10's release date (June 2022 earliest).

Rerolled #103 into a merge request, updated Symfony components, applied #3162016: [Symfony 6] Retrieving a non-string value from "Symfony\Component\HttpFoundation\InputBag::get()" is deprecated, and removed all three Symfony 5 deprecations as they should now be fixed.

+------------------------------------+---------+---------+
| Production Changes                 | From    | To      |
+------------------------------------+---------+---------+
| symfony/console                    | v4.4.21 | v5.2.6  |
| symfony/debug                      | v4.4.20 | REMOVED |
| symfony/dependency-injection       | v4.4.21 | v5.2.6  |
| symfony/error-handler              | v4.4.21 | v5.2.6  |
| symfony/event-dispatcher           | v4.4.20 | v5.2.4  |
| symfony/event-dispatcher-contracts | v1.1.9  | v2.2.0  |
| symfony/http-foundation            | v4.4.20 | v5.2.4  |
| symfony/http-kernel                | v4.4.21 | v5.2.6  |
| symfony/process                    | v4.4.20 | v5.2.4  |
| symfony/routing                    | v4.4.20 | v5.2.6  |
| symfony/serializer                 | v4.4.20 | v5.2.4  |
| symfony/translation                | v4.4.21 | v5.2.6  |
| symfony/validator                  | v4.4.21 | v5.2.6  |
| symfony/yaml                       | v4.4.21 | v5.2.5  |
| psr/event-dispatcher               | NEW     | 1.0.0   |
| symfony/polyfill-intl-grapheme     | NEW     | v1.22.1 |
| symfony/string                     | NEW     | v5.2.6  |
+------------------------------------+---------+---------+

+------------------------------+---------+---------+
| Dev Changes                  | From    | To      |
+------------------------------+---------+---------+
| behat/mink-browserkit-driver | v1.3.4  | dc566b2 |
| symfony/browser-kit          | v4.4.20 | v5.2.4  |
| symfony/css-selector         | v4.4.20 | v5.2.4  |
| symfony/dom-crawler          | v4.4.20 | v5.2.4  |
| symfony/filesystem           | v4.4.21 | v5.2.6  |
| symfony/finder               | v4.4.20 | v5.2.4  |
| symfony/lock                 | v4.4.21 | v5.2.6  |
+------------------------------+---------+---------+

Opened #3209239: [Symfony 5] Symfony\Contracts\EventDispatcher\Event subclasses need return types and merged it here as that is the cause of many of the test failures.

Opened #3209482: [Symfony 6] Update EventDispatcherInterface type hint in FileUploadResource constructor as that is the cause of most of the rest of the test failures.

Merged in #3209459: Switch to friends of behat MinkBrowserKitDriver for PHP 8 and Symfony 5 compatibility which should hopefully get us a green test run.

Next step is to try the 5.3 beta.

Lots of failures due to this change in symfony/http-kernel: https://github.com/symfony/symfony/pull/39893/files

Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'{"message":"No route found for \u0022GET \/not-found\u0022"}'
+'{"message":"No route found for \u0022GET http:\/\/localhost\/not-found\u0022"}'

Opened three new issues for SF5.3 deprecations:

#3209617: [Symfony 6] Symfony\Component\HttpFoundation\RequestStack::getMasterRequest() is deprecated, use getMainRequest() instead
#3209618: [Symfony 6] Symfony\Component\HttpKernel\Event\KernelEvent::isMasterRequest() is deprecated, use isMainRequest() instead
#3209619: [Symfony 6] Passing null as $message to Symfony exception constructors is deprecated, pass an empty string instead

Remaining two fails are a vendor hardening issue for #3209459: Switch to friends of behat MinkBrowserKitDriver for PHP 8 and Symfony 5 compatibility and ComposerProjectTemplatesTest refusing to allow non-stable dependencies which is #3186364: Allow pre-release dependencies in Drupal pre-release milestones.

There are other deprecations but does no effect, more interesting looks new helpers on request stack to get session https://github.com/symfony/http-foundation/blob/5.x/CHANGELOG.md

Updated the MR to Symfony 5.3.0-beta3.

symfony/dependency-injection appears to have a hard dependency on symfony/config when running on PHP 8, I can reproduce with a minimal test case:

$ composer require symfony/dependency-injection:^5.3@beta

$ cat test.php
<?php

require 'vendor/autoload.php';

new Symfony\Component\DependencyInjection\Compiler\PassConfig();

$ php8.0 test.php
PHP Fatal error:  Uncaught Error: Class "Symfony\Component\Config\Loader\FileLoader" not found in vendor/symfony/dependency-injection/Loader/FileLoader.php:32

Raised #124 over at https://github.com/symfony/symfony/issues/41169 to see what Symfony maintainers have to say here.

The three fails are all build related, one is #3186364: Allow pre-release dependencies in Drupal pre-release milestones because we are using a Symfony beta and the other two are related to the Symfony patch but will be resolved when the patch lands in a release.

Fixed beta is out https://github.com/symfony/symfony/releases/tag/v5.3.0-BETA4

SF 6 branch is open, and https://github.com/symfony/symfony/releases/tag/v5.3.0-RC1 is out

Looking at the changelog I am not sure it is worth updating here again until 5.3.0 is out or 5.4 opens.

$ composer-lock-diff --no-links --from=origin/9.3.x
+------------------------------------+---------+------------+
| Production Changes                 | From    | To         |
+------------------------------------+---------+------------+
| symfony/console                    | v4.4.24 | v5.3.0-RC1 |
| symfony/debug                      | v4.4.22 | REMOVED    |
| symfony/dependency-injection       | v4.4.24 | v5.3.0-RC1 |
| symfony/error-handler              | v4.4.23 | v5.3.0-RC1 |
| symfony/event-dispatcher           | v4.4.20 | v5.3.0-RC1 |
| symfony/event-dispatcher-contracts | v1.1.9  | v2.4.0     |
| symfony/http-foundation            | v4.4.23 | v5.3.0-RC1 |
| symfony/http-kernel                | v4.4.24 | v5.3.0-RC1 |
| symfony/mime                       | v5.2.9  | v5.3.0-RC1 |
| symfony/process                    | v4.4.22 | v5.3.0-RC1 |
| symfony/routing                    | v4.4.24 | v5.3.0-RC1 |
| symfony/serializer                 | v4.4.24 | v5.3.0-RC1 |
| symfony/translation                | v4.4.24 | v5.3.0-RC1 |
| symfony/validator                  | v4.4.24 | v5.3.0-RC1 |
| symfony/var-dumper                 | v5.2.8  | v5.3.0-RC1 |
| symfony/yaml                       | v4.4.24 | v5.3.0-RC1 |
| psr/event-dispatcher               | NEW     | 1.0.0      |
| symfony/polyfill-intl-grapheme     | NEW     | v1.22.1    |
| symfony/string                     | NEW     | v5.2.8     |
+------------------------------------+---------+------------+

+------------------------+---------+------------+
| Dev Changes            | From    | To         |
+------------------------+---------+------------+
| symfony/browser-kit    | v4.4.24 | v5.3.0-RC1 |
| symfony/css-selector   | v4.4.24 | v5.3.0-RC1 |
| symfony/dom-crawler    | v4.4.24 | v5.3.0-RC1 |
| symfony/filesystem     | v4.4.22 | v5.3.0-RC1 |
| symfony/finder         | v4.4.24 | v5.3.0-RC1 |
| symfony/lock           | v4.4.23 | v5.3.0-RC1 |
| symfony/phpunit-bridge | v5.2.9  | v5.3.0-RC1 |
+------------------------+---------+------------+

Removing issues from the issue summary that landed:

• #3209618: [Symfony 6] Symfony\Component\HttpKernel\Event\KernelEvent::isMasterRequest() is deprecated, use isMainRequest() instead
• #3162016: [Symfony 6] Retrieving a non-string value from "Symfony\Component\HttpFoundation\InputBag::get()" is deprecated
• #3209617: [Symfony 6] Symfony\Component\HttpFoundation\RequestStack::getMasterRequest() is deprecated, use getMainRequest() instead

Fantastic!

Also given #3209459: Switch to friends of behat MinkBrowserKitDriver for PHP 8 and Symfony 5 compatibility landing earlier, removing this section from the issue summary, since it is not relevant anymore as far as I understand:

Also, it is currently not possible to run browser tests on Symfony 5, since Mink browser hasn't been updated for Symfony 5 yet:

https://github.com/minkphp/MinkBrowserKitDriver/issues/139
https://github.com/minkphp/MinkBrowserKitDriver/pull/151
https://github.com/minkphp/MinkBrowserKitDriver/pull/142

Also moving #3196027: Contrib support solution needed for potential Symfony 4 to 6 upgrade, Symfony 5 only deprecations are not available in Symfony 4 to its own section since it is not in the same scope as the other core issues.

We also have #3209723: [Symfony 6] Symfony\Component\HttpKernel\HttpKernelInterface::MASTER_REQUEST is deprecated, use ::MAIN_REQUEST instead, that needs to be fixed.

Thanks to @effulgentsia for lots of work on #3186364: Allow pre-release dependencies in Drupal pre-release milestones which means we are finally green on this MR with an RC release of Symfony.

Good news that Symfony has figured out deprecation notices for return type additions, we can surely borrow this technique ourselves.

Good news that Symfony has figured out deprecation notices for return type additions, we can surely borrow this technique ourselves.

@longwave: Do you have a link for that?

@daffie: Symfony's DebugClassLoader provides this functionality; there is no documentation yet but https://github.com/symfony/symfony/pull/42623 is the PR where this was added to SF 5.4.

A couple more type hint fixes:

• #3231676: [Symfony 6] Add various type hints to Drupal\Core\TypedData\Validation\RecursiveValidator::inContext() and ::startContext()
• #3231672: [Symfony 6] Add "Definition" type hint to Drupal\Core\DependencyInjection\ContainerBuilder::setDefinition()
• #3231669: [Symfony 6] Add "Alias" type hint to Drupal\Core\DependencyInjection\ContainerBuilder::setAlias()
• #3231668: [Symfony 6] Add "Definition" type hint to Drupal\Core\DependencyInjection\ContainerBuilder::register()
• #3231673: [Symfony 6] Add "ContextualValidatorInterface" type hint to Drupal\Core\TypedData\Validation\RecursiveValidator::startContext()

Yet again couple more type hint fixes:

• #3231682: [Symfony 6] Add "ConstraintViolationListInterface" type hint to Drupal\Core\TypedData\Validation\RecursiveValidator::validate(), ::validateProperty() and ::validatePropertyValue()
• #3231686: [Symfony 6] Add "ConstraintViolationBuilderInterface" type hint to Drupal\Core\TypedData\Validation\ExecutionContext::buildViolation()
• #3231688: [Symfony 6] Add type hints to Drupal\Core\TypedData\Validation\ExecutionContext
• #3231689: [Symfony 6] Add type hints to Drupal\Core\TypedData\Validation\ExecutionContext::getObject(), ::getMetadata(), ::getGroup(), ::getClassName(), ::getPropertyName() and ::getPropertyPath()
• #3231690: [Symfony 6] Add type hints to Drupal\Core\TypedData\Validation\TypedDataMetadata::findConstraints(), ::getConstraints(), ::getTraversalStrategy() and ::getCascadingStrategy()
• #3231693: [Symfony 6] Add type hints to Drupal\Component\Annotation\Doctrine\SimpleAnnotationReader::getClassAnnotations(), ::getMethodAnnotations(), ::getPropertyAnnotations(), ::getClassAnnotation(), ::getMethodAnnotation() and ::getPropertyAnnotation()

Fixing #3231683: [Symfony 6] A number of methods of the class Drupal\Core\TypedData\Validation\ExecutionContext are considered internal and Drupal should not override them. will be a bit more difficult.

Yet again a couple of new return type hint fixes that can be committed to D9:

• #3232095: [Symfony 6] Refactor the "update.root" service to return an object not a string
• #3232110: [Symfony 6] Add type hints to the methods Drupal\Component\EventDispatcher\ContainerAwareEventDispatcher::getListeners(), ::getListenerPriority() and ::hasListeners()
• #3232113: [Symfony 6] Add "static" type hint to the method Drupal\Component\HttpFoundation\SecuredRedirectResponse::setTargetUrl()

The ones that have to wait for D10:

• #3232082: [Symfony 6] Add "Response" type hint to methods that implement the method Symfony\Component\HttpKernel\HttpKernelInterface::handle()
• #3232080: [Symfony 6] Add "mixed" type hint to all Normalizer classes that implement the method ::denormalize()
• #3232074: [Symfony 6] Add "array|string|int|float|bool|\ArrayObject|null" to all Normalizer classes that implement the method ::normalize()
• #3232063: [Symfony 6] Add "bool" type hint to Drupal\serialization\Normalizer\NormalizerBase::supportsNormalization() and subclasses
• #3232092: [Symfony 6] Add "string|array" to the method Drupal\Component\DependencyInjection\Dumper\OptimizedPhpArrayDumper::dump()
• #3232097: [Symfony 6] Add "array" type hint to methods overriding Symfony\Component\EventDispatcher\EventSubscriberInterface::getSubscribedEvents()

@catch: Thank you for updating the MR for Symfony 5.4. It makes it easier to see which ones still need to be done. Could you do it again?

The following issues have landed:

• #3231686: [Symfony 6] Add "ConstraintViolationBuilderInterface" type hint to Drupal\Core\TypedData\Validation\ExecutionContext::buildViolation()
• #3231689: [Symfony 6] Add type hints to Drupal\Core\TypedData\Validation\ExecutionContext::getObject(), ::getMetadata(), ::getGroup(), ::getClassName(), ::getPropertyName() and ::getPropertyPath()
• #3231690: [Symfony 6] Add type hints to Drupal\Core\TypedData\Validation\TypedDataMetadata::findConstraints(), ::getConstraints(), ::getTraversalStrategy() and ::getCascadingStrategy()
• #3232110: [Symfony 6] Add type hints to the methods Drupal\Component\EventDispatcher\ContainerAwareEventDispatcher::getListeners(), ::getListenerPriority() and ::hasListeners()
• #3232888: [Symfony 6] Add "array" type hint to the method Drupal\Core\Routing\UrlMatcher::getAttributes()
• #3233023: [Symfony 6] Add "RouteCollection" type hint to methods overridding Symfony\Component\Routing\RouterInterface::getRouteCollection()
• #3233045: [Symfony 6] Add "array" type hint to methods overridding Symfony\Component\Routing\Matcher\RequestMatcherInterface::matchRequest()
• #3233464: [Symfony 6] Add "ExecutionContextInterface" type hint to methods overriding Symfony\Component\Validator\Context\ExecutionContextFactoryInterface::createContext()
• #3233481: [Symfony 6] Add type hints to the methods overriding Symfony\Component\Validator\Mapping\Factory\MetadataFactoryInterface::getMetadataFor() and ::hasMetadataFor()

Moved #3231688: [Symfony 6] Add type hints to Drupal\Core\TypedData\Validation\ExecutionContext to the must be done in the 10.0 branch.

Moved #3232082: [Symfony 6] Add "Response" type hint to methods that implement the method Symfony\Component\HttpKernel\HttpKernelInterface::handle() back to the list that can be done in 9.3.

Adding #3236563: [Symfony 6] Add "static" type hint to the methods overriding Symfony\Component\HttpFoundation\Response::sendContent() to the must wait for the D10.0 branch.

Moved #3232095: [Symfony 6] Refactor the "update.root" service to return an object not a string over to the update module. This issue needs special attention, because it is failing update tests.

Added #3238210: The mocked method in Drupal\Tests\Core\Routing\LazyRouteCollectionTest does not return an ArrayIiterator to the todo list.

The adds Symfony 5.4-dev package and a number of yet to be committed patches:

• #3236563: [Symfony 6] Add "static" type hint to the methods overriding Symfony\Component\HttpFoundation\Response::sendContent()
• #3233456: [Symfony 6] Add "int" type hint to methods overriding Symfony\Component\Console\Command\Command::execute()
• #3232063: [Symfony 6] Add "bool" type hint to Drupal\serialization\Normalizer\NormalizerBase::supportsNormalization() and subclasses
• #3236243: [Symfony 6] Add "callable|false" type hint to methods overriding Symfony\Component\HttpKernel\Controller\ControllerResolverInterface::getController()
• #3231688: [Symfony 6] Add type hints to Drupal\Core\TypedData\Validation\ExecutionContext
• #3233474: [Symfony 6] Add the type hints to the methods overriding Symfony\Component\Validator\Validator\ContextualValidatorInterface::atPath(), ::getViolations(), ::validateProperty() and ::validatePropertyValue()
• #3233479: [Symfony 6] Add type hints to the methods overriding Symfony\Component\Validator\Violation\ConstraintViolationBuilderInterface::atPath(), ::setParameter(), ::setParameters(), ::setTranslationDomain(), ::setInvalidValue(), ::setPlural(), ::setCode() and ::
• #3238210: The mocked method in Drupal\Tests\Core\Routing\LazyRouteCollectionTest does not return an ArrayIiterator
• #3233031: [Symfony 6] Add "RequestContext" type hint to methods overridding Symfony\Component\Routing\RequestContextAwareInterface::getContext()
• #3232892: [Symfony 6] Add "static" type hint to the method Drupal\Core\Routing\RequestContext::fromRequest()
• #3232832: [Symfony 6] Add various type hints to Drupal\serialization\Encoder\JsonEncoder::supportsEncoding() and ::supportsDecoding() and Drupal\serialization\Encoder\XmlEncoder::supportsEncoding(), ::encode(), ::decode() and ::supportsDecoding()
• #3232095: [Symfony 6] Refactor the "update.root" service to return an object not a string

#3238210: The mocked method in Drupal\Tests\Core\Routing\LazyRouteCollectionTest does not return an ArrayIiterator has landed.

The remaining deprecation warnings for deprecations from Symfony 5.4 are from:

1. Symfony\Cmf package which is deprecated and will be removed before D10.
2. #3232074: [Symfony 6] Add "array|string|int|float|bool|\ArrayObject|null" to all Normalizer classes that implement the method ::normalize() (jsonapi.module)
3. #3232095: [Symfony 6] Refactor the "update.root" service to return an object not a string (update.module)
4. #3231683: [Symfony 6] A number of methods of the class Drupal\Core\TypedData\Validation\ExecutionContext are considered internal and Drupal should not override them.

Moved #3233031: [Symfony 6] Add "RequestContext" type hint to methods overridding Symfony\Component\Routing\RequestContextAwareInterface::getContext() and #3232097: [Symfony 6] Add "array" type hint to methods overriding Symfony\Component\EventDispatcher\EventSubscriberInterface::getSubscribedEvents() to the must be done in the 10.0 branch.

Moved #3232074: [Symfony 6] Add "array|string|int|float|bool|\ArrayObject|null" to all Normalizer classes that implement the method ::normalize() back to the list of stuff that must be done in the 9.3 branch.