Problem/Motivation

When a poll is configured to allow to view the results before voting, on the poll form a button "View results" disappear.

When going to the poll results as anonymous user (when the poll accepts anonymous votes), a button called "View poll" appears.
But when going to the poll as authenticated user, there is no "View poll" button.

I found out that this bug was introduced in #2944773: View poll button.

Additionally, there is a PHP notice when an authenticated user goes to the poll results before voting, but that's a different bug. And that one only occurs on later PHP versions, so it seems. I shall create a separate issue for this.

I noticed this issue while working on #3178162: Serialization error when switching between poll form and poll results as an anonymous user on PHP 7.4 and there it causes the tests to be less consistent.

Steps to reproduce

  1. Create a poll that allows to view the results before voting.
  2. As an authenticated user, go to the poll. The poll form gets displayed.
  3. Click the "View results" button. The poll vote results get displayed.

There is no "View poll" button, while there is one when accessing the poll as anonymous user.

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

A patch with tests will follow. The posted test is similar to the one posted in #3178162: Serialization error when switching between poll form and poll results as an anonymous user on PHP 7.4.

CommentFileSizeAuthor
#12 3178172-12.patch4.43 KBaskibinski
#6 interdiff-3178172-3-5.txt2.43 KBMegaChriz
#5 poll-view-poll-button-missing-3178172-5.patch4.3 KBMegaChriz
#5 poll-view-poll-button-missing-3178172-5-tests-only.patch1.2 KBMegaChriz
#3 poll-view-poll-button-missing-3178172-3.patch3.55 KBMegaChriz
#2 poll-view-poll-button-missing-3178172-2.patch1.21 KBMegaChriz

Issue fork poll-3178172

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

MegaChriz created an issue. See original summary.

MegaChriz’s picture

MegaChriz CreditAttribution: MegaChriz at WebCoo commented
Status: Active » Needs work
FileSize
poll-view-poll-button-missing-3178172-2.patch1.21 KB

This is the tests only patch, I also plan to work on a fix, though that one will be borrowing code from #2909811: Anonymous users - Multiple voting from one IP.

MegaChriz’s picture

MegaChriz CreditAttribution: MegaChriz at WebCoo commented
Status: Needs work » Needs review
FileSize
poll-view-poll-button-missing-3178172-3.patch3.55 KB

I think that this patch will fix the issue.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Status: Needs review » Needs work 
+++ b/src/Form/PollViewForm.php
@@ -147,16 +147,8 @@ class PollViewForm extends FormBase implements BaseFormIdInterface {
+      // Voting is no longer allowed.

this is/was a really weird switch statement anyway and you just removed most cases. The $account variable is also unused now. Lets simplify to just a single return show results || isVotingAllowed?

Needs a reroll now anyway because the test conflicts.

MegaChriz’s picture

MegaChriz CreditAttribution: MegaChriz at WebCoo commented
Status: Needs work » Needs review
FileSize
poll-view-poll-button-missing-3178172-5-tests-only.patch1.2 KB
poll-view-poll-button-missing-3178172-5.patch4.3 KB

Here is a reroll + the following changes:

  • The implementation of PollViewForm::showResults() is simplified, following the suggestion from #4.
  • Added function docblock to PollViewForm::showResults().
  • Fixed a single deprecation issue in PollVoteTest::testViewPollAndPollResultsAsAuthenticatedUser(). See https://www.drupal.org/node/3168858.
MegaChriz’s picture

MegaChriz CreditAttribution: MegaChriz at WebCoo commented
FileSize
interdiff-3178172-3-5.txt2.43 KB

Also adding an interdiff.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented

the changes to test seem incomplete aka are only the interdiff in all versions of the patch.

MegaChriz’s picture

MegaChriz CreditAttribution: MegaChriz at WebCoo commented

Not sure why the patches didn't apply. I try with issue branches instead now...

MegaChriz opened merge request !2

MegaChriz opened merge request !3

MegaChriz’s picture

MegaChriz CreditAttribution: MegaChriz at WebCoo commented

Hiding the patches.

askibinski’s picture

askibinski CreditAttribution: askibinski as a volunteer commented
Status: Needs review » Reviewed & tested by the community
FileSize
3178172-12.patch4.43 KB

MR works as expected, button now appears on results page and works with ajax.
Created a patch based on the latest MR for those that prefer such.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 12: 3178172-12.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

MegaChriz’s picture

MegaChriz CreditAttribution: MegaChriz at WebCoo commented

Better hide the patch as it can confuse the testbot. I also triggered a retest for the MR to check if test failures are also in there.

mpaulo’s picture

mpaulo
He/Him
CreditAttribution: mpaulo at CI&T commented

Is this still reproducible?

seanB made their first commit to this issue’s fork.

ivnish’s picture

ivnish CreditAttribution: ivnish commented

@BramDriesen is this already fixed in #3426799: Back to poll button only appears when allow anonymous vote is enabled ?

BramDriesen’s picture

BramDriesen
he/him
Primary language Dutch
Location Belgium 🇧🇪🇪🇺
CreditAttribution: BramDriesen as a volunteer and at Sopra Steria commented
Version: 8.x-1.x-dev » 2.0.x-dev
Assigned: Unassigned » BramDriesen
Category: Bug report » Task
Related issues: +#3426799: Back to poll button only appears when allow anonymous vote is enabled

Partially yes. This seems to simplify some other things as well. Will backport those relevant changes to 2.0.x

BramDriesen closed merge request !2

BramDriesen opened merge request !37

BramDriesen closed merge request !3

  • BramDriesen committed 95e02d9f on 2.0.x 
    Issue #3178172 by MegaChriz, seanB, askibinski, Berdir, ivnish: Button "...
BramDriesen’s picture

BramDriesen
he/him
Primary language Dutch
Location Belgium 🇧🇪🇪🇺
CreditAttribution: BramDriesen as a volunteer and at Sopra Steria commented
Status: Needs work » Fixed
Issue tags: +MountainCamp2024

Committed the relevant changes to 2.0.x. Thanks all! The test coverage was increased for this in #3426799: Back to poll button only appears when allow anonymous vote is enabled

BramDriesen’s picture

BramDriesen
he/him
Primary language Dutch
Location Belgium 🇧🇪🇪🇺
CreditAttribution: BramDriesen as a volunteer and at Sopra Steria commented
Assigned: BramDriesen » Unassigned

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.