Problem/Motivation

During an upgrade to D9 we also upgraded to the 3.x version of VBO, and our content admin pagers stopped working correctly with exposed filter results. If you set filters to return only 3 content items (for example) the full pager remains in place for ALL content items. This issue was reported earlier as fixed for D8 but it appears to be back. See here for explanation and working patch for D9:

Original issue: https://www.drupal.org/project/views_bulk_operations/issues/3056119
Screenshot: https://www.drupal.org/files/issues/2019-05-24/Screenshot_3.png
Patch (#30): https://www.drupal.org/files/issues/2021-05-09/3056119-30.patch

This patch is working for us on D 9.1.9+VBO 3.x-dev -- I also commented on that issue but since it is closed and I have no ability to re-open I thought I would post here to make sure somebody sees it. Feel free to merge/close this post if needed, thanks!

CommentFileSizeAuthor
#3 3216144-3.patch656 bytesgraber

Comments

broeker created an issue. See original summary.

broeker’s picture

broeker commented
Issue summary: View changes
graber’s picture

graber commented
Status: Active » Needs review
StatusFileSize
new 3216144-3.patch656 bytes

Can you try this instead?

acbramley’s picture

acbramley commented

I can confirm #3 fixes the pager issues with exposed filters. Would be great to get some tests added so this doesn't regress again.

urvashi_vora’s picture

urvashi_vora commented

The patch given in #3 is tested for PHP 7.4 & MySQL 5.7 for D9.2 11 and is working.

urvashi_vora’s picture

urvashi_vora commented
Status: Needs review » Reviewed & tested by the community
urvashi_vora’s picture

urvashi_vora commented
Status: Reviewed & tested by the community » Fixed
graber’s picture

graber commented
Status: Fixed » Reviewed & tested by the community

Issue is not fixed until the fix is committed. I'll handle it when I'll have some more time.

  • Graber committed 9a5ef27 on 4.0.x 
    Issue #3216144 by Graber: (D9) Broken pager with exposed filters
graber’s picture

graber commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed. Yes, would be nice to have test coverage..

friverobalidea’s picture

friverobalidea commented

Tested in Drupal 8.9.19, PHP 7.3.21 and MySQL 5.6.43 and did not work. After apply several filters and obtain one single result in the view, the pager still shows the access to all pages and makes no sense. This is an example of what happens with this configuration: https://pasteboard.co/gyQjMYOK3aVK.png

liquidcms’s picture

liquidcms commented

i cant confirm for sure that this is related to exposed filters.. but vbo is certainly messing up the pager.

with some filtering (exposed or not) i see "Displaying 1-40 of 493", yet the vbo select all box shows: "Select / deselect all results in this view (all pages, 21176 total)" and the pager lists ALL pages.

Oddly enough, as soon as I pick a page everything gets fixed:
- pager shows correct number of pages
- Select / deselect all results in this view (all pages, 493 total)

even going back to First page works correctly.

forgot to mention:
- this is with D8.9.16
- vbo 8.x-3.13 or 4.0.0
- with or without patch (patch only applies to 8)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.