Problem/Motivation

if ($pager_offset = $this->view->pager->getOffset()) { on ViewsBulkOperationsActionProcessor.
The pager is not set resulting in the following error:

Error: Call to a member function getOffset() on null in /var/www/html/web/modules/contrib/views_bulk_operations/src/Service/ViewsBulkOperationsActionProcessor.php on line 241

VBO 3.13, Drupal 8.9.15.

CommentFileSizeAuthor
#13 vbo_3217543_d8_13.patch553 bytesnavneet0693
#12 vbo-3217543-12.patch551 bytesressinel
#6 vbo-3217543-6.patch513 bytesressinel

Issue fork views_bulk_operations-3217543

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

krystalcode created an issue. See original summary.

krystalcode’s picture

krystalcode commented
Issue summary: View changes

krystalcode opened merge request !14

krystalcode’s picture

krystalcode commented

I have created an MR with a check that the pager is set before calling a method on it. Not sure if that's the correct solution, should the pager always be set and there's something missing elsewhere?

ressinel’s picture

ressinel
Location 🇺🇦 Rivne
commented

I have the same error. After some investigation, I got that changes by this issue raise the error.

ressinel’s picture

ressinel
Location 🇺🇦 Rivne
commented
StatusFileSize
new vbo-3217543-6.patch513 bytes

Here's the patch that helps me to fix this error.

ressinel’s picture

ressinel
Location 🇺🇦 Rivne
commented
Status: Active » Needs review
navneet0693’s picture

navneet0693 commented
Status: Needs review » Reviewed & tested by the community
graber’s picture

graber commented
Status: Reviewed & tested by the community » Needs work

The merge request needs to be rebased and the patch doesn't apply. Also not sure what's RTBCed - the MR or the patch?

navneet0693’s picture

navneet0693 commented
Version: 8.x-3.x-dev » 4.0.x-dev
ressinel’s picture

ressinel
Location 🇺🇦 Rivne
commented

I have updated the patch.

ressinel’s picture

ressinel
Location 🇺🇦 Rivne
commented
StatusFileSize
new vbo-3217543-12.patch551 bytes
navneet0693’s picture

navneet0693 commented
Status: Needs work » Needs review
StatusFileSize
new vbo_3217543_d8_13.patch553 bytes
navneet0693’s picture

navneet0693 commented

@Graber The RTBC was for the patch, somehow the previous was getting applied via the composer.

  • Graber committed 5593793 on 4.0.x authored by Ressinel 
    Issue #3217543 by Ressinel, krystalcode, navneet0693: Pager view not...
graber’s picture

graber commented
Status: Needs review » Fixed

Sorry it took so much time to commit this.

ressinel’s picture

ressinel
Location 🇺🇦 Rivne
commented

@Graber I see that you have reverted changes of this issue in this commit. We should add them again since views_bulk_operations 4.0.1 release has this issue marked as fixed: https://www.drupal.org/project/views_bulk_operations/releases/4.0.1

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

graber’s picture

graber commented

Ahh, indeed. Re-added in https://git.drupalcode.org/project/views_bulk_operations/-/commit/8b821c....
Thank you!