Problem/Motivation

Based on report from @Luke.Leber on #3231364-41: Add CKEditor 5 module to Drupal core, I was able to discover bug where h4, h5, and h6 fail to downcast GHS added attributes. This is because CKEditor 5 hasn't defined proper mappings for these elements in https://github.com/ckeditor/ckeditor5/blob/master/packages/ckeditor5-htm....

Steps to reproduce

Remaining tasks

User interface changes

API changes

Data model changes

Comments

lauriii created an issue. See original summary.

lauriii’s picture

Wim Leers’s picture

Title: h4, h5, and h6 fail to downcast GHS added attributes » [upstream] h4, h5, and h6 fail to downcast GHS added attributes
Status: Active » Postponed
catch’s picture

Title: [upstream] h4, h5, and h6 fail to downcast GHS added attributes » h4, h5, and h6 fail to downcast GHS added attributes
Status: Postponed » Active

The upstream issue is fixed.

Wim Leers’s picture

https://github.com/ckeditor/ckeditor5/releases/tag/v30.0.0 is the latest release, from 20 days ago.

https://github.com/ckeditor/ckeditor5/pull/10664 fixed this, and was merged 6 days ago.

Just asked @Reinmar when the next CKEditor 5 release is expected. We don't need to wait for it per se, but if it's coming soon, we might as well wait for that :)

Wim Leers’s picture

Status: Active » Postponed

It's going to be released tomorrow, October 26: https://github.com/ckeditor/ckeditor5/issues/10637. Let's wait for that :)

Wim Leers’s picture

Title: h4, h5, and h6 fail to downcast GHS added attributes » [PP-1] [upstream] h4, h5, and h6 fail to downcast GHS added attributes
Issue tags: -Needs upstream bugfix

#3245942: Update CKEditor 5 to 31.0.0 will update our CKE5 build to today's release, that should fix this!

Wim Leers’s picture

Title: [PP-1] [upstream] h4, h5, and h6 fail to downcast GHS added attributes » [upstream] h4, h5, and h6 fail to downcast GHS added attributes
Status: Postponed » Reviewed & tested by the community

Matching status of #3245942: Update CKEditor 5 to 31.0.0 and granting issue credit.

Wim Leers credited Reinmar.

Wim Leers’s picture

Crediting CKEditor 5 folks too.

Wim Leers’s picture

Status: Reviewed & tested by the community » Fixed

#3245942: Update CKEditor 5 to 31.0.0 was marked fixed; forgot to mark this fixed too. I manually verified that this was fixed, see #3245942-7: Update CKEditor 5 to 31.0.0.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.